Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Schemes]: Screen reader does not announce the 'default' visible text defined with the 'Campbell' color scheme on the page. #14401

Closed
Shubham786786 opened this issue Nov 17, 2022 · 5 comments · Fixed by #14704 or #15486
Closed

[Color Schemes]: Screen reader does not announce the 'default' visible text defined with the 'Campbell' color scheme on the page. #14401

Shubham786786 opened this issue Nov 17, 2022 · 5 comments · Fixed by #14704 or #15486
Assignees
@PankajBhojwani
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.19

Comments

@Shubham786786
Copy link

Windows Terminal version

1.17.3052.0

Windows build number

Windows 11 Version 22H2 (OS Build 25206.1000)

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal.
  2. Open 'Settings > Startup' window with 'Ctrl+,' keys.
  3. Turn on Narrator by 'Ctrl+Win+Enter' keys.
  4. Navigate to 'Color schemes' list item by down arrow key and select it.
  5. Navigate to 'Campbel' by the tab key.
  6. Observe the Narrator's announcement here.

User Experience: -
Screen reader users will have to navigate in scan mode to get this value information defined with the color control.

Guideline Reference:
(https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html)

Attachments:
Screen reader does not announce the 'default' visible text defined with the 'Campbell' color scheme on the page..zip

Expected Behavior

Screen reader should announce the 'default' visible text defined with the 'Campbell' color scheme on the page. It should announce as 'Campbell, default, 1 of 11 selected'.

Actual Behavior

Screen reader does not announce the 'default' visible text defined with the 'Campbell' color scheme on the page. It announces as 'Campbell, 1 of 11 selected'.

Observation:

Issue also reproes with the NVDA screen reader.
@Shubham786786 Shubham786786 added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Nov 17, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Dec 6, 2022
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 6, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 6, 2022
@carlos-zamora carlos-zamora mentioned this issue Dec 6, 2022
Closed
@carlos-zamora carlos-zamora added the Product-Terminal The new Windows Terminal. label Dec 6, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 6, 2022
@zadjii-msft
Copy link
Member

FWIW, this still repros on the current Color Schemes page, circa 1.17.3481.0

@PankajBhojwani PankajBhojwani mentioned this issue Jan 19, 2023
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jan 19, 2023
@ghost ghost closed this as completed in #14704 Jan 19, 2023
ghost pushed a commit that referenced this issue Jan 19, 2023
@PankajBhojwani
Manually set the automation name of the default color scheme for scre…
47f38e3 
…en reader (#14704)

## Summary of the Pull Request
When we navigate to the color schemes page, find the default color scheme (if present) and manually set the container's automation name to include the word 'default'. 

Note that we don't want to change the actual `ColorSchemeViewModel`'s name since that name is used internally to identify schemes. We only want to change the `ListViewItem`'s name, i.e. the container in the SUI.

## PR Checklist
* [x] Closes #14401 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
Screen reader reads out the 'default' text now. It also correctly reads out the new default scheme if the default scheme is changed via SUI or json.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 19, 2023
@DHowett
Copy link
Member

DHowett commented Jan 24, 2023 •
edited
Loading

Reverted due to a virtualization-related crash in 7d0baa7 (main) ab79a85 (release-1.17).

@zadjii-msft
Copy link
Member

@DHowett Should we reopen this then? Or just file a new bug to track the crash?

@DHowett
Copy link
Member

DHowett commented Jan 24, 2023

Ha, I actually did mean to reopen it. Thanks!

@DHowett DHowett reopened this Jan 24, 2023
@DHowett DHowett removed the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 24, 2023
@ghost

This comment was marked as outdated.

Sign in to view
@zadjii-msft zadjii-msft removed this from the Terminal v1.18 milestone May 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone May 12, 2023
@carlos-zamora carlos-zamora mentioned this issue May 30, 2023
Merged
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 30, 2023
microsoft-github-policy-service bot pushed a commit that referenced this issue Jun 5, 2023
@carlos-zamora
Expose 'Default' tag to Screen Readers in Color Schemes page (#15486)
0425ab0 
## Summary of the Pull Request
This removes the "default" text box from the UI Automation tree, thus
preventing screen readers from navigating to it. This was a confusing
scenario for users because the "default" tag was unclear if it was a
part of the previous or next color scheme (i.e. consider hearing
"Campbell, default, Campbell PowerShell"; it's unclear which one is
default).

This also appends the "default" string to the `ToString` function of the
color scheme view model. This makes it so that the combo box and list
view visually appear the same, but can be quick searched or read out by
the screen reader with the 'default' tag.

## Validation Steps Performed
- [x] Verified this works on Windows 11
- [x] Verified this works on Windows 10
- Scenarios tested:
   - [x] saving settings after changing the default scheme
   - [x] saving settings.json to force a refresh in SUI

Closes #14401
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Expose 'Default' tag to Screen Readers in Color Schemes page (#15486)
4247381 
## Summary of the Pull Request
This removes the "default" text box from the UI Automation tree, thus
preventing screen readers from navigating to it. This was a confusing
scenario for users because the "default" tag was unclear if it was a
part of the previous or next color scheme (i.e. consider hearing
"Campbell, default, Campbell PowerShell"; it's unclear which one is
default).

This also appends the "default" string to the `ToString` function of the
color scheme view model. This makes it so that the combo box and list
view visually appear the same, but can be quick searched or read out by
the screen reader with the 'default' tag.

## Validation Steps Performed
- [x] Verified this works on Windows 11
- [x] Verified this works on Windows 10
- Scenarios tested:
   - [x] saving settings after changing the default scheme
   - [x] saving settings.json to force a refresh in SUI

Closes #14401

(cherry picked from commit 0425ab0)
Service-Card-Id: 90012453
Service-Version: 1.17
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Expose 'Default' tag to Screen Readers in Color Schemes page (#15486)
1b1a9ee 
## Summary of the Pull Request
This removes the "default" text box from the UI Automation tree, thus
preventing screen readers from navigating to it. This was a confusing
scenario for users because the "default" tag was unclear if it was a
part of the previous or next color scheme (i.e. consider hearing
"Campbell, default, Campbell PowerShell"; it's unclear which one is
default).

This also appends the "default" string to the `ToString` function of the
color scheme view model. This makes it so that the combo box and list
view visually appear the same, but can be quick searched or read out by
the screen reader with the 'default' tag.

## Validation Steps Performed
- [x] Verified this works on Windows 11
- [x] Verified this works on Windows 10
- Scenarios tested:
   - [x] saving settings after changing the default scheme
   - [x] saving settings.json to force a refresh in SUI

Closes #14401

(cherry picked from commit 0425ab0)
Service-Card-Id: 90012454
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.19
5 participants
@DHowett @carlos-zamora @zadjii-msft @PankajBhojwani @Shubham786786