Expose 'Default' tag to Screen Readers in Color Schemes page #15486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
This comment was marked as outdated.
This comment was marked as outdated.
carlos-zamora
force-pushed
the
dev/cazamor/read-default-scheme-tag
branch
from
3c2c328
to
2e64d93
Compare
lhecker
previously approved these changes
May 31, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
carlos-zamora
force-pushed
the
dev/cazamor/read-default-scheme-tag
branch
from
4220a50
to
71058f9
Compare
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Jun 1, 2023
|
Make sure the description is up to date! |
PankajBhojwani
approved these changes
Jun 2, 2023
|
@msftbot merge this in 10 minutes |
carlos-zamora
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/cazamor/read-default-scheme-tag
branch
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
## Summary of the Pull Request This removes the "default" text box from the UI Automation tree, thus preventing screen readers from navigating to it. This was a confusing scenario for users because the "default" tag was unclear if it was a part of the previous or next color scheme (i.e. consider hearing "Campbell, default, Campbell PowerShell"; it's unclear which one is default). This also appends the "default" string to the `ToString` function of the color scheme view model. This makes it so that the combo box and list view visually appear the same, but can be quick searched or read out by the screen reader with the 'default' tag. ## Validation Steps Performed - [x] Verified this works on Windows 11 - [x] Verified this works on Windows 10 - Scenarios tested: - [x] saving settings after changing the default scheme - [x] saving settings.json to force a refresh in SUI Closes #14401 (cherry picked from commit 0425ab0) Service-Card-Id: 90012453 Service-Version: 1.17
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
## Summary of the Pull Request This removes the "default" text box from the UI Automation tree, thus preventing screen readers from navigating to it. This was a confusing scenario for users because the "default" tag was unclear if it was a part of the previous or next color scheme (i.e. consider hearing "Campbell, default, Campbell PowerShell"; it's unclear which one is default). This also appends the "default" string to the `ToString` function of the color scheme view model. This makes it so that the combo box and list view visually appear the same, but can be quick searched or read out by the screen reader with the 'default' tag. ## Validation Steps Performed - [x] Verified this works on Windows 11 - [x] Verified this works on Windows 10 - Scenarios tested: - [x] saving settings after changing the default scheme - [x] saving settings.json to force a refresh in SUI Closes #14401 (cherry picked from commit 0425ab0) Service-Card-Id: 90012454 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This removes the "default" text box from the UI Automation tree, thus preventing screen readers from navigating to it. This was a confusing scenario for users because the "default" tag was unclear if it was a part of the previous or next color scheme (i.e. consider hearing "Campbell, default, Campbell PowerShell"; it's unclear which one is default).
This also appends the "default" string to the
ToStringfunction of the color scheme view model. This makes it so that the combo box and list view visually appear the same, but can be quick searched or read out by the screen reader with the 'default' tag.Validation Steps Performed
Closes #14401