Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Freeway-Bug}[Settings>Default terminal application]: Options present for the 'Default terminal application' combo box are getting truncated at 200% zoom. #15149

Closed
Saiteja341 opened this issue Apr 10, 2023 · 0 comments · Fixed by #15762
Closed

{Freeway-Bug}[Settings>Default terminal application]: Options present for the 'Default terminal application' combo box are getting truncated at 200% zoom. #15149

Saiteja341 opened this issue Apr 10, 2023 · 0 comments · Fixed by #15762
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.19

Comments

@Saiteja341
Copy link

Windows Terminal version

1.18.902.0

Windows build number

23031.1000

Other Software

Test environment:
OS: Version 22H2 (OS build 23031.1000)
Application: Windows Terminal
Screen reader: Narrator

Steps to reproduce

Pre-requisite:
Apply the resize using following path.
Settings>Accessibility>Display>Display resolution>Change display resolution to '1280 x 720>Keep changes>Drag the 'Text size' slider to '200%'>Apply>Re-open the application.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Log in with valid credentials.
  3. Follow the above-mentioned pre-requisite step.
  4. Open settings using 'Ctrl + ,'.
  5. Navigate to 'Start up' list-item & select it.
  6. Navigate to the 'Default terminal application' combo box & activate it.
  7. Navigate among the options present in the expanded combo box.
  8. Observe the issue.

User experience:
Users with low vision rely on zooming features for navigation will feel difficulty in understanding the purpose of options present for the combo box, if options are not visible properly at 200% zoom.

Guideline reference:
https://www.w3.org/TR/WCAG21/#resize-text

Attachment:
Options present for the combo box are not visible properly on re-sizing..zip

Expected Behavior

In 200% zoom, options present for the expanded 'Default terminal application' combo box should be visible completely without any overlapping, as they visible in 100%zoom.

Actual Behavior

Options present for the 'Default terminal application' combo box are getting truncated & overlapping at 200% zoom.
@Saiteja341 Saiteja341 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 10, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Apr 10, 2023
@Saiteja341 Saiteja341 changed the title [Settings>Default terminal application]: Options present for the 'Default terminal application' combo box are getting truncated at 200% zoom. {Freeway-Bug}[Settings>Default terminal application]: Options present for the 'Default terminal application' combo box are getting truncated at 200% zoom. Apr 11, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Apr 13, 2023
@carlos-zamora carlos-zamora mentioned this issue Jul 25, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jul 25, 2023
DHowett pushed a commit that referenced this issue Jul 26, 2023
@carlos-zamora
Fix Default Terminal and Color Scheme ComboBoxes cropping at 200% Tex…
1f9426b 
…t Size (#15762)

When the OS' "text size" setting gets set to 200% and the display
resolution is reduced quite a bit, we get some cropped text in the SUI's
Default Terminal ComboBox. Turns out, we have a height set on the items.
I went ahead and removed that so we don't crop the text. Everything
looks good still!

A similar issue occurs in the Profile > Appearance > Color Scheme
ComboBox. I went ahead and fixed that too by removing the height
restriction.

Other minor changes:
- fixed the comments
- changed "author and version" row to "auto" instead of "*" (star sizing
is great for proportional sizing, so we're not really taking advantage
of it)

Closes #15149
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 26, 2023
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Fix Default Terminal and Color Scheme ComboBoxes cropping at 200% Tex…
18c6d27 
…t Size (#15762)

When the OS' "text size" setting gets set to 200% and the display
resolution is reduced quite a bit, we get some cropped text in the SUI's
Default Terminal ComboBox. Turns out, we have a height set on the items.
I went ahead and removed that so we don't crop the text. Everything
looks good still!

A similar issue occurs in the Profile > Appearance > Color Scheme
ComboBox. I went ahead and fixed that too by removing the height
restriction.

Other minor changes:
- fixed the comments
- changed "author and version" row to "auto" instead of "*" (star sizing
is great for proportional sizing, so we're not really taking advantage
of it)

Closes #15149

(cherry picked from commit 1f9426b)
Service-Card-Id: 89991190
Service-Version: 1.17
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Fix Default Terminal and Color Scheme ComboBoxes cropping at 200% Tex…
d31f81a 
…t Size (#15762)

When the OS' "text size" setting gets set to 200% and the display
resolution is reduced quite a bit, we get some cropped text in the SUI's
Default Terminal ComboBox. Turns out, we have a height set on the items.
I went ahead and removed that so we don't crop the text. Everything
looks good still!

A similar issue occurs in the Profile > Appearance > Color Scheme
ComboBox. I went ahead and fixed that too by removing the height
restriction.

Other minor changes:
- fixed the comments
- changed "author and version" row to "auto" instead of "*" (star sizing
is great for proportional sizing, so we're not really taking advantage
of it)

Closes #15149

(cherry picked from commit 1f9426b)
Service-Card-Id: 89991191
Service-Version: 1.18
@similar-issues-ai similar-issues-ai bot mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.19
Development

Successfully merging a pull request may close this issue.

Fix Default Terminal and Color Scheme ComboBoxes cropping at 200% Text Size microsoft/terminal
3 participants
@zadjii-msft @Priyanka-Chauhan123 @Saiteja341