Fix Default Terminal and Color Scheme ComboBoxes cropping at 200% Text Size #15762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
previously approved these changes
Jul 25, 2023
lhecker
previously approved these changes
Jul 26, 2023
|
Went ahead and checked the Profile > Appearance > Color Scheme ComboBox too. 
Changed it to this:
Admittedly, the color chips don't look right to me. But I tried playing around with them and no luck. At least the text isn't cropped anymore |
carlos-zamora
changed the title
carlos-zamora
dismissed stale reviews from lhecker and DHowett
Changed scope of PR
lhecker
approved these changes
Jul 26, 2023
DHowett
approved these changes
Jul 26, 2023
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
…t Size (#15762) When the OS' "text size" setting gets set to 200% and the display resolution is reduced quite a bit, we get some cropped text in the SUI's Default Terminal ComboBox. Turns out, we have a height set on the items. I went ahead and removed that so we don't crop the text. Everything looks good still! A similar issue occurs in the Profile > Appearance > Color Scheme ComboBox. I went ahead and fixed that too by removing the height restriction. Other minor changes: - fixed the comments - changed "author and version" row to "auto" instead of "*" (star sizing is great for proportional sizing, so we're not really taking advantage of it) Closes #15149 (cherry picked from commit 1f9426b) Service-Card-Id: 89991190 Service-Version: 1.17
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
…t Size (#15762) When the OS' "text size" setting gets set to 200% and the display resolution is reduced quite a bit, we get some cropped text in the SUI's Default Terminal ComboBox. Turns out, we have a height set on the items. I went ahead and removed that so we don't crop the text. Everything looks good still! A similar issue occurs in the Profile > Appearance > Color Scheme ComboBox. I went ahead and fixed that too by removing the height restriction. Other minor changes: - fixed the comments - changed "author and version" row to "auto" instead of "*" (star sizing is great for proportional sizing, so we're not really taking advantage of it) Closes #15149 (cherry picked from commit 1f9426b) Service-Card-Id: 89991191 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OS' "text size" setting gets set to 200% and the display resolution is reduced quite a bit, we get some cropped text in the SUI's Default Terminal ComboBox. Turns out, we have a height set on the items. I went ahead and removed that so we don't crop the text. Everything looks good still!
A similar issue occurs in the Profile > Appearance > Color Scheme ComboBox. I went ahead and fixed that too by removing the height restriction.
Other minor changes:
Closes #15149