-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization - Typos/consistency errors in French in closing contextual menu #16819
Comments
Just to clarify the expected behavior, the cascading menu item also needs to be fixed:
The uppercases of some items seems weird to me even in English, but if you want to keep them and want French to be consistent with other languages:
(note the To be fair, it feels weird in English as well, and just looks even worse in French because it is applied only to some menu items and because determiners make them lose their left alignments, making it worse visually. Oh, and those |
… misuse (#16886) I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places. Fixes issues #16819 and #16846 ## PR Checklist - [ ] Closes #16846 - [x] Tests added/passed - NA - [x] Documentation updated - NA - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [x] Schema updated (if necessary) - NA
… misuse (#16886) I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places. Fixes issues #16819 and #16846 ## PR Checklist - [ ] Closes #16846 - [x] Tests added/passed - NA - [x] Documentation updated - NA - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [x] Schema updated (if necessary) - NA (cherry picked from commit 8bd9578) Service-Card-Id: 92350387 Service-Version: 1.20
… misuse (#16886) I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places. Fixes issues #16819 and #16846 ## PR Checklist - [ ] Closes #16846 - [x] Tests added/passed - NA - [x] Documentation updated - NA - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [x] Schema updated (if necessary) - NA (cherry picked from commit 8bd9578) Service-Card-Id: 92350386 Service-Version: 1.19
The fermer vs. fermez issue does seem resolved now. I'm not entirely sure either whether capitalizing Pane in French is a good idea. It's a little weird even in the English original IMO. |
Windows Terminal version
1.19.10573.0
Windows build number
10.0.19045.4046
Other Software
No response
Steps to reproduce
Open the Terminal (splitting the tab helps discover one more string)
Expected Behavior
The contextual menu should contain "Fermer" (infinitive) and not "Fermez" (imperative)
Submenu should contain "Fermer les onglets à droite" / "Fermer les autres onglets" / "Fermer le volet"
Actual Behavior
Casing and conjugation are inconsistent
Conjugation: a mix of infinitive and imperative while the rest of the UI is, correctly, using infinitive
Casing: those strings are using uppercase starting words while the rest of the UI is, correctly, using an uppercase letter only for the first letter of the text
The text was updated successfully, but these errors were encountered: