Fix: UI style errors: Menu items capitalization and … (ellipses) mark misuse #16886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@microsoft-github-policy-service agree |
lhecker
approved these changes
Mar 18, 2024
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
|
May I know what's stopping this PR from being merged? |
Pull requests require two approvals and other team members haven't had time to check this PR out yet. That's basically it. 😅 |
carlos-zamora
approved these changes
Apr 10, 2024
|
Thanks for merging! |
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
… misuse (#16886) I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places. Fixes issues #16819 and #16846 ## PR Checklist - [ ] Closes #16846 - [x] Tests added/passed - NA - [x] Documentation updated - NA - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [x] Schema updated (if necessary) - NA (cherry picked from commit 8bd9578) Service-Card-Id: 92350387 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
… misuse (#16886) I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places. Fixes issues #16819 and #16846 ## PR Checklist - [ ] Closes #16846 - [x] Tests added/passed - NA - [x] Documentation updated - NA - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [x] Schema updated (if necessary) - NA (cherry picked from commit 8bd9578) Service-Card-Id: 92350386 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
This was referenced Aug 14, 2024
DHowett
pushed a commit
that referenced
this pull request
Aug 21, 2024
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684
DHowett
pushed a commit
that referenced
this pull request
Aug 21, 2024
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684 (cherry picked from commit 0a7c258) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSFdXc Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the improper capitalization and misuse of ellipses mark (...) in the context menu and various other places.
Fixes issues #16819 and #16846
PR Checklist