-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #17037
Add files via upload #17037
Conversation
@@ -187,6 +187,9 @@ | |||
<data name="Quit" xml:space="preserve"> | |||
<value>Quit</value> | |||
</data> | |||
<data name="CloseWindowWarningTitle" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resource seems to not be used anywhere?
@@ -215,10 +218,10 @@ | |||
<value>Web search</value> | |||
</data> | |||
<data name="TabColorChoose" xml:space="preserve"> | |||
<value>Change tab color</value> | |||
<value>Color...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this literally the opposite of what was done in #16886
</data> | ||
<data name="TabColorCustomButton.Content" xml:space="preserve"> | ||
<value>Custom</value> | ||
<value>Custom...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and here too)
@@ -835,7 +835,7 @@ | |||
<value>Close this tab</value> | |||
</data> | |||
<data name="NewTabMenuFolderEmpty" xml:space="preserve"> | |||
<value>Empty</value> | |||
<value>Empty...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and here too)
I think what happened here is that lsmith took a snapshot of the file as it was when they started working, and re-uploaded it via the GitHub web UI after they made their modifications. If that's the case - there are some changes that need to be integrated from #16886! |
Okay we looked over it all again - looks like #16886 took care of things here. Thanks anyways! |
Summary of the Pull Request
Edited Resources.resw to reflect the style guidlines
References and Relevant Issues
Issue #16846
Detailed Description of the Pull Request / Additional comments
Edited Resources.resw to reflect the desired style guidelines. Specifically sentence style capitalization and use of elipses.
Validation Steps Performed
PR Checklist