We broke nt... in the Command Palette
#17294
Labels
Area-CmdPal
Command Palette issues and features
In-PR
This issue has a related PR
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Comments
zadjii-msft
added
Issue-Bug
|
(just go read the whole thread) |
microsoft-github-policy-service
bot
added
Needs-Tag-Fix
carlos-zamora
removed
the
Needs-Triage
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
This was referenced Aug 14, 2024
DHowett
pushed a commit
that referenced
this issue
Aug 21, 2024
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684 (cherry picked from commit 0a7c258) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSFdXc Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
oh yea I didn't even thing about that. I kind of hate it now.
Actually wait we probably should entirely revert that for the commands. Because now the (formerly) "New tab..." (&pane) command names conflict with the un-nested ones, so there's no nested New Tab item at all anymore. Yikes.
Originally posted by @zadjii-msft in #17200 (reply in thread)
The text was updated successfully, but these errors were encountered: