Add elipses back in to some command names #17715
Conversation
microsoft-github-policy-service
bot
added
Issue-Bug
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
| @@ -445,7 +445,7 @@ | |||
| <value>Switch to the last tab</value> | |||
| </data> | |||
| <data name="TabSearchCommandKey" xml:space="preserve"> | |||
| <value>Search for tab</value> | |||
| <value>Search for tab...</value> | |||
There was a problem hiding this comment.
Should this (these?) use … instead?
There was a problem hiding this comment.
My vote is that Search for tab... should have the ... because the action is requesting more information before it's completed. Invoking the action doesn't search; it opens a new control that then requests for more information (via textbox) to then search for the tab.
Based this decision on generalizing this, but open to discuss and change 😊.
There was a problem hiding this comment.
I meant whether we should use the dedicated ellipsis Unicode character for this: https://www.compart.com/en/unicode/U+2026
There was a problem hiding this comment.
Oh! My stance is "eh". Is there a value to switching over to the unicode character? Screen readers seem to handle it no differently.
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
| <value>Open suggestions</value> | ||
| <value>Open suggestions...</value> |
There was a problem hiding this comment.
Reverting this one. We use it here so it'd look weird with the .... Besides, we actually are opening the suggestions. We're not necessarily asking for more information.
There was a problem hiding this comment.
i'm not gonna block, but also I dunno if I really love not having the ... on nested commands anymore. I miss them. We're not really a traditional nested menu, so the same UX guidelines don't really apply.
But maybe also that's just me being overly attached to nt. as my "pick the profile" shorthand.
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
DHowett and
lhecker
microsoft-github-policy-service
bot
removed
the
Needs-Second
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684 (cherry picked from commit 0a7c258) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSFdXc Service-Version: 1.21
In #16886, the key for the nested action got renamed from
Split Pane...toSplit pane. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version.I tried to balance the stylistic recommendations from #16846 (mainly this comment since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency.
Side effect of #16886 which closed #16846
Closes #17294, #17684