-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add ellipses back in to some command names (#17715)
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684
- Loading branch information
1 parent
a40a4ea
commit 0a7c258
Showing
1 changed file
with
8 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters