Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] A confirmation dialect window show up before closing the current tab. #1864

Closed
were opened this issue Jul 8, 2019 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@were
Copy link

were commented Jul 8, 2019

Summary of the new feature/enhancement

Is it possible, to implement something like this:
When there is an active process in the current tab, a confirmation dialect window may show up before actually closing.

When I was writing vim, I need to use C-W to switch among vim tabs.
C-W is also the hotkey to close the current tab.
When the first two times I ran into this problem, I suppose it was some crashing thing.
Finally, I realized it was a hotkey conflict.

Proposed technical implementation details (optional)

I did not dive into the code base of this project yet, but I hope it is not too hard to implement.

@were were added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 8, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2019
@zadjii-msft
Copy link
Member

This seems like a good feature request. I think we've mentioned it somewhere else in another thread, but this is a good setting. Something like:

"promptBeforeClosing": bool

or similar, to control whether the dialog appears or not. Or something like

"suppressCloseDialog": bool

and display the dialog by default when we notice there's more than one child* process attached to the terminal

*: not including conhost of course

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 8, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2019
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jul 8, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 8, 2019
@were
Copy link
Author

were commented Jul 9, 2019

Is there any branch implementing this? If not, I can take it.

@zadjii-msft
Copy link
Member

@were nope, not yet. Feel free to take a stab at it!

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2019
@zadjii-msft
Copy link
Member

Hey so this was partially implemented in #2526, to resolve #1589.

There's also #2976, which tracks a follow-up to #2526 to connect more settings to the dialog. Since that issue seems to have a few more details, I'm going to close this one in favor of that one. Thanks!

/dup #1589
/dup #2976

@ghost
Copy link

ghost commented Nov 6, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 6, 2019
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Nov 6, 2019
@zadjii-msft zadjii-msft removed the Help Wanted We encourage anyone to jump in on these. label Nov 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants