Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Alt+F4 work and warn the user about terminating more than one tab #1589

Closed
arnederuwe opened this issue Jun 25, 2019 · 6 comments
Closed
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@arnederuwe
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable): 0.2.1715.0

Steps to reproduce

Start The terminal app, try to close it using Alt + F4

Expected behavior

The app should close

Actual behavior

The app doesn't close, which is inconsistent with 99% of windows apps

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 25, 2019
@Shorotshishir
Copy link

On Second Thought.
PowerShell and WSL individually don't close on alt+f4 as they don't have it set for the task. Windows Terminal shows it has alt+f4 set to close but it doesn't work. perhaps they are trying to make it consistent with the rest two.

@DHowett-MSFT DHowett-MSFT changed the title Bug Report: Alt + F4 doesn't work Make Alt+F4 work and stop the user from terminating more than one tab Jun 27, 2019
@DHowett-MSFT DHowett-MSFT changed the title Make Alt+F4 work and stop the user from terminating more than one tab Make Alt+F4 work and warn the user about terminating more than one tab Jun 27, 2019
@DHowett-MSFT
Copy link
Contributor

This is now the tracking issue for getting alt+f4 working and adding a dialog to stop users from harming their running session state.

@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jun 27, 2019
@DHowett-MSFT DHowett-MSFT removed the Help Wanted We encourage anyone to jump in on these. label Aug 26, 2019
@praneetloke
Copy link

It would also be nice if there was an option to prompt the user about closing a tab that has a running program. For example, running a development server of some kind in a tab in interactive mode (vs. daemon mode) is often a development workflow for all sorts of apps (Angular CLI, webpack-based apps, Node apps etc.) these days.

@DHowett-MSFT
Copy link
Contributor

This was fixed by #2526.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 24, 2019
@DHowett-MSFT DHowett-MSFT added the Resolution-Fix-Available It's available in an Insiders build or a release label Sep 24, 2019
@codenotworking
Copy link

I don't think this was fixed, because #17613 exists.

@DHowett
Copy link
Member

DHowett commented Aug 18, 2024

@codenotworking thanks, we’ll keep all further discussion over there rather than on this five year old issue.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

8 participants