Enable Terminal closing with ALT + F4 and warning of multiple open tabs

[KaiyuWang16]

Summary of the Pull Request

This PR is for: #1589
We add a key binding called "CloseWindow", which will close the whole terminal, and warn the user if multiple tabs are opened. The user could choose to cancel or continue the closing action.

References

PR Checklist

• Closes #xxx
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

In my Page-App refactoring change: #2208, _showDialog's signature is changed. I only pass a ContentDialog to it and the contents are constructed in each specific dialog initialization methods. In this PR, I follow this pattern.

Testing:

1. check-out this branch and build the project
2. Start terminal app
3. Open settings, add
   {
   "command": "closeWindow",
   "keys": [
   "alt+f4"
   ]
   }
   to the end of the "keybindings" list.
4. Open multiple tabs by clicking "+"
5. Press alt + F4.
6. On the dialog, choose ""cancel", then the dialog will close and nothing happens.
7. Press alt + F4. On the dialog, click "OK". Then the app will close.

[DHowett-MSFT]

I like this. We should file a followup workitem for the following additional work:

• When the user clicks on the X button, they should receive the same prompt.
  • This must work for the IslandWindow and the NonClientIslandWindow.
  • The close must be suppressed if the user says No.

[DHowett-MSFT]

Is there a way we can get an x in the top right corner of this dialog, like Edge has?

[KaiyuWang16]

Is there a way we can get an x in the top right corner of this dialog, like Edge has?

Seems that ContentDialog does not have this by default. We could customize ContentDialog, but in this way we will lose the built-in title/text/buttons and will have to provide those by ourselves.

[codendone]

Couple small changes suggested. Otherwise looks good.

[zadjii-msft]

Does this work with both light and dark mode? Are the buttons visible even when the app's theme is opposite the system theme? This probably won't update if you change the theme while the dialog is open, but I don't think any of ours do ATM.

Overall this seems like a fine starting point to me. I'd love to have a lot more customization around this in the future, but this is a good enough start. I still have a couple questions so I'm not going to sign off quite yet.

[KaiyuWang16]

Does this work with both light and dark mode? Are the buttons visible even when the app's theme is opposite the system theme? This probably won't update if you change the theme while the dialog is open, but I don't think any of ours do ATM.
Overall this seems like a fine starting point to me. I'd love to have a lot more customization around this in the future, but this is a good enough start. I still have a couple questions so I'm not going to sign off quite yet.

In "dark" theme, the content dialog will change to "dark" but the buttons remain the same:

[DHowett-MSFT]

Before you merge this, please change the title.

Pretend that you are completing the sentence, "This commit will..."

Remember: pull request titles and commit titles are supposed to read like e-mail subject lines. They should be concise, imperative, and convey enough useful information so that somebody looking at history will be able to understand them.
They are permanent.

[KaiyuWang16]

Before you merge this, please change the title.
Pretend that you are completing the sentence, "This commit will..."
Remember: pull request titles and commit titles are supposed to read like e-mail subject lines. They should be concise, imperative, and convey enough useful information so that somebody looking at history will be able to understand them.
They are permanent.

Title changed. Will pay attention to the PR and commit titles in the future.

[DHowett-MSFT]

Thanks!

[ghost]

🎉Windows Terminal Preview v0.5.2661.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[xieofxie]

Hi, please add warning for clicking 'close' on the upper right too~ Thanks~