-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to define color 256 causes temporary hang #3720
Comments
Note that this is not a conhost issue - it only fails in Windows Terminal. The exact source of the error is in the terminal/src/cascadia/TerminalCore/TerminalApi.cpp Lines 401 to 405 in 99a8337
That test should be |
Ooh, good catch. Thanks for finding that @j4james! |
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Uses the verification in `at` to ensure the index is correct (as @j4james suggests). If `at` throws, then returns false. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3720 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] ~~I've~~ discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3720 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Can no longer repro the issue after the fix.
🎉This issue was addressed in #3938, which has now been successfully released as Handy links: |
Environment
Steps to reproduce
Trying to redefine the exact RGB value for color index 256:
Expected behavior
Nothing, because the index is out of range.
Actual behavior
The next shell prompt and the command as I type it doesn't appear. It takes a newline or so to get out of this state.
Note: This issue only occurs with exactly 256. With bigger numbers there's no hang.
The text was updated successfully, but these errors were encountered: