Fix SetColorTableEntry off-by-one error #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Dec 12, 2019
|
You're right this and #3936 should have tests. I'll commit those. |
Only tests SetColorTableEntry right now
|
For the record, I was kind of hoping the exception could be handled further up in the call stack, so it could potentially catch exceptions from any operation - not just this particular case. That said, I don't know how feasible that is, and any fix is better than nothing, so I wouldn't object to this PR as is. |
mkitzan
changed the title
zadjii-msft
added
Area-VT
ghost
requested review from
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett-MSFT
approved these changes
Dec 14, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Uses the verification in
atto ensure the index is correct (as @j4james suggests). Ifatthrows, then returns false.References
PR Checklist
I'vediscussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Trying to define color 256 causes temporary hang #3720Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Can no longer repro the issue after the fix.