Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y_Windows Terminal_Search or Find Operation_Screen Reader: After entering the text and performing search operation the screen reader is not reading whether that particular word is present or not in the terminal #5421

Closed
SpandanaPaladi opened this issue Apr 20, 2020 · 8 comments
Closed

A11y_Windows Terminal_Search or Find Operation_Screen Reader: After entering the text and performing search operation the screen reader is not reading whether that particular word is present or not in the terminal #5421

SpandanaPaladi opened this issue Apr 20, 2020 · 8 comments
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.2

Comments

@SpandanaPaladi
Copy link

SpandanaPaladi commented Apr 20, 2020 •
edited
Loading

#A11y_WindowsTerminal; #WindowsTerminal; #A11yMAS; #A11yTCS; #DesktopApp; #Win10; #C+E-H; #ScreenReader; #Narrator; #NVDA; #A11ySev2; #NonBenchMark; #MAS1.3.1

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Turn on screen reader
  2. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  3. Open ""Windows terminal (Preview)"" application
  4. Use "Alt + Shift + F" to perform search/find operation
  5. Verify whether the screen reader is reading that particular word which is searched is present in the terminal or not

Actual Result:
Narrator/NVDA is not reading whether the searched word is present in the terminal or not

Expected Result:​
Narrator/NVDA should read whether the searched word is present in the terminal or not

User Impact:​
Screen Reader users will face difficulty if the screen reader don't read whether the searched word is present or not in the terminal because they don't understand whether the searched word is present or not

MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Bug_Narrator not reading the searched word.pptx
Bug_NVDA not reading the searched word.pptx
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 20, 2020
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Apr 20, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 20, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 20, 2020
@carlos-zamora carlos-zamora mentioned this issue Apr 22, 2020
Merged
1 task
carlos-zamora added a commit that referenced this issue Apr 29, 2020
@carlos-zamora
Notify UIA when Search finds something (#5478)
6d41072 
## Summary of the Pull Request
Before this, if the Search Box was open, new selections would not notify automation clients. This was because the UiaEngine (responsible for notifying automation clients) would remain disabled. Now we're enabling it before the early exit in TermControl's FocusHandler

## PR Checklist
* [X] Will close issue #5421 upon verification

## Validation Steps Performed
Verified using NVDA.
Narrator's behavior is not impacted, for some reason.
@carlos-zamora carlos-zamora added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 29, 2020
@carlos-zamora
Copy link
Member

@SpandanaPaladi are you still seeing this issue, or can we close it?

@Neurrone
Copy link

when the search term is not found, pressing enter on the find dialog announces nothing. It would be ideal if some message was announced to the effect that it was not found.

When it is found, NVDA reads the search term. I find that this behaviour is not that intuitive.

What does work well is that when escaping out of the find dialog, NVDA's review cursor is positioned at the starting position of the match for you to review around it.

@carlos-zamora carlos-zamora mentioned this issue Jun 2, 2020
Closed
@carlos-zamora
Copy link
Member

@SpandanaPaladi are we compliant given the current state? Can we close this issue?

@Neurrone What you're requesting is a good idea, but I think with regards to tracking, it's slightly separate from what this issue is talking about. That said, I've opened issue #6319 to track it.

@Neurrone
Copy link

Neurrone commented Jun 3, 2020

Looking at the issue title, I think it should remain open because nothing is read if no matches are found.

I agree that the UX for when text is found and how its conveyed should be in its own issue.

@Neurrone
Copy link

Neurrone commented Jun 3, 2020

Oh, I see why you split it off in its own issue. I don't mind closing this or leaving this open while the proper UX is implemented in #6319.

@Amulya-95
Copy link

Amulya-95 commented Jun 12, 2020 •
edited
Loading

Now NVDA is reading regarding the searched keyword but Narrator is not reading anything. Still able to reproduce the issue with Narrator.

[Not Fixed]Bug 5421_Narrator not reading regarding searched keyword.pptx

Bug 5421_NVDA is reading when user search any keyword.pptx

@Amulya-95
Copy link

Please provide the Sample app, so that we will file bug to Narrator team and will close the current bug as it is working fine with another free screen reader (NVDA)

@SpandanaPaladi
Copy link
Author

Logged External bug https://microsoft.visualstudio.com/OS/_workitems/edit/27084958 to Narrator team.

Closing the current bug as it is working fine with NVDA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.2
Development

No branches or pull requests
7 participants
@carlos-zamora @DHowett-MSFT @Neurrone @zadjii-msft @cinnamon-msft @Amulya-95 @SpandanaPaladi