-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: show an indicator if there's a bell in the tab #8106
Comments
OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory. |
Oh I knew exactly what you meant by this, don't sweat 😆 We've had mockups of this dating back to some of the earliest Terminal mockups actually. I'm surprised we didn't already have an issue for it, but that makes sense considering we only just landed the bell in #7679. I'm mildly worried that we're going to be stuffing a lot of info into the tab pretty soon - the "zoom" indicator, the progress ring, the bell/mute indicator, but I'm not that worried. I think the number of people who are doing all simultaneously will be fairly low. |
If you decide to implement the status bar, things like Zoom indication could go there. I see little reason you need to know a tab's console has been zoomed, unless it is the current active tab. |
This is closely related to #1608, if not a duplicate. |
I agree that this is closely related, but I'm gonna hold off calling this a dupe. I think I'd rather have this issue specifically track displaying the bell icon in the tab, and the other issue for displaying the alert in the taskbar. They're pretty similar, but I could see people wanting one or the other (or neither, or both), so we should probably have them all configurable independently. I'll add both of them over to #6700, because they're sorta related. They're all about displaying some state to the user either with the tab or the taskbar. |
How long should a bell indicator stay on the tab btw? |
Maybe like 1 second, then a 1 second fade? I suppose it should be just about the same as if a Edgium tab played a bell, for consistency. |
When we emit a BEL (visual or audible), show an indicator in the tab header If the tab the BEL is coming from is not focused when the BEL is raised, the indicator in its header will be removed when the tab gains focus. If the tab was already focused when the BEL was emitted, then the indicator goes away after 2 seconds. Closes #8106
When we emit a BEL (visual or audible), show an indicator in the tab header If the tab the BEL is coming from is not focused when the BEL is raised, the indicator in its header will be removed when the tab gains focus. If the tab was already focused when the BEL was emitted, then the indicator goes away after 2 seconds. Closes microsoft#8106
While the audible bell is very annoying, the visual bell is kinda hard to notice. Maybe instead of plan bell icon, 🔔 can be used? Also bell icon only prepends to tab title, maybe It can be appended to taskbar title too. Or superimpose a little bell icon to taskbar's terminal icon.... |
Description of the new feature/enhancement
This is a pretty straight-forward one. I know iTerm2 has this. As a ex-iOS developer I found it very useful to not only hear the bell but also know which tab is actually triggering the bell.
Proposed technical implementation details (optional)
I think we need a spec for this, to display some kind of accessories in the tab, besides icon and title.
The text was updated successfully, but these errors were encountered: