Make tab header a custom control #8227

PankajBhojwani · 2020-11-11T17:11:50Z

This PR makes the Header of TabViewItem a custom user control.

Validation Steps Performed

Manual testing

src/cascadia/TerminalApp/TabHeaderControl.cpp

zadjii-msft

Overall this looks pretty good, but I wanna block for discussion on passing the TabBase to the HeaderControl, so hopefully more of this can just be magic

src/cascadia/TerminalApp/TabHeaderControl.cpp

zadjii-msft · 2020-11-16T16:34:29Z

src/cascadia/TerminalApp/TerminalTab.cpp

@@ -37,6 +37,17 @@ namespace winrt::TerminalApp::implementation

        _MakeTabViewItem();
        _CreateContextMenu();
+
+        // Add an event handler for the header control to tell us when they want their title to change
+        _headerControl.HeaderTitleChanged([weakThis = get_weak()](auto&& title) {


Do we need to author a custom event (HeaderTitleChanged) for this? Since Title is observable, shouldn't we be able to do this with the automatic PropertyChanged event?

For ex, TerminalPage.cppL1143-1163, we'd probably do something similar:

_headerControl.PropertyChanged([weakThis=get_weak()](auto&&, const WUX::Data::PropertyChangedEventArgs& args) { if (auto tab{ weakThis.get() }) { if (args.PropertyName() == L"Title") { tab->SetTabText(title); } } });

Ah I should rename this event - the purpose of this event is to let the hosting tab know that the user tried to change the title to x, and once the tab receives that event it tells the headerControl to change its title to x.

The reason for this is so its always the tab that has ownership over the title

(the event was named this way in the first iteration when the headerControl indeed just changed the title and simply wanted to let the tab know about it, now its more like it tells the tab/asks the tab's permission to change its title)

src/cascadia/TerminalApp/TabHeaderControl.idl

zadjii-msft

Yea, these are all nits. Thanks for finally biting the bullet on this 🙌

src/cascadia/TerminalApp/TabHeaderControl.h

src/cascadia/TerminalApp/TabHeaderControl.cpp

src/cascadia/TerminalApp/TabHeaderControl.idl

src/cascadia/TerminalApp/TabHeaderControl.xaml

DHowett · 2020-11-20T04:37:43Z

src/cascadia/TerminalApp/TabHeaderControl.xaml

+        <FontIcon x:Name="HeaderZoomIcon"
+                  FontFamily="Segoe MDL2 Assets"
+                  Visibility="Collapsed"
+                  Glyph="&#xE8A3;"
+                  FontSize="12"
+                  Margin="0,0,8,0"/>
+        <TextBlock x:Name="HeaderTextBlock"
+                   Visibility="Visible"
+                   Text="{x:Bind Title, Mode=OneWay}"/>
+        <TextBox x:Name="HeaderRenamerTextBox"
+                 Visibility="Collapsed"
+                 MinHeight="0"
+                 Padding="4,0,4,0"
+                 Margin="0,-8,0,-8"


let's make sure this still works under accessibility. @carlos-zamora wanna help out?

src/cascadia/TerminalApp/TabHeaderControl.xaml

src/cascadia/TerminalApp/TabHeaderControl.cpp

DHowett · 2020-11-20T04:40:10Z

Sorry, I hate to block for things i mostly called nits 😄

DHowett

Love it! Thanks 😄

ghost · 2020-11-20T17:16:09Z

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

This PR makes the Header of TabViewItem a custom user control. ## Validation Steps Performed Manual testing Closes microsoft#8201

ghost · 2021-01-28T18:02:19Z

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

initial

3b1a5e9

PankajBhojwani mentioned this pull request Nov 11, 2020

[DRAFT] Make tab header a custom control #8225

Closed

6 tasks

PankajBhojwani added 2 commits November 11, 2020 15:42

rename box

40c6920

inform hosting tab when title changes, comments

52cc864

PankajBhojwani changed the title ~~[DRAFT] Make tab header a custom control~~ Make tab header a custom control Nov 11, 2020

PankajBhojwani marked this pull request as ready for review November 11, 2020 22:15

ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Nov 11, 2020

spell

e37b225

DHowett requested changes Nov 11, 2020

View reviewed changes

src/cascadia/TerminalApp/TabHeaderControl.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 11, 2020

store current title

613efc5

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 13, 2020

send event to tab for them to update our title

01243cc

zadjii-msft mentioned this pull request Nov 16, 2020

Feature Request: show an indicator if there's a bell in the tab #8106

Closed

zadjii-msft requested changes Nov 16, 2020

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 16, 2020

PankajBhojwani added 2 commits November 16, 2020 13:53

address comments

4ef5fda

rename event

83a02f1

zadjii-msft approved these changes Nov 18, 2020

View reviewed changes

addressing comments

b092b88

PankajBhojwani requested a review from DHowett November 19, 2020 18:35

DHowett requested changes Nov 20, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 20, 2020

addressing comments

47ba949

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 20, 2020

DHowett approved these changes Nov 20, 2020

View reviewed changes

DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 20, 2020

ghost merged commit a77b494 into main Nov 20, 2020

ghost deleted the dev/pabhoj/tab_header_control branch November 20, 2020 17:16

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Nov 22, 2020

Make tab header a custom control (microsoft#8227)

e895852

This PR makes the Header of TabViewItem a custom user control. ## Validation Steps Performed Manual testing Closes microsoft#8201

mpela81 mentioned this pull request Nov 22, 2020

Tab title stop changing dynamically after rename textbox is dismissed #8365

Closed

zadjii-msft mentioned this pull request Nov 30, 2020

Set Tab tooltip explicitly #8298

Merged

6 tasks

ghost mentioned this pull request Jan 28, 2021

Make the TabViewItemHeader a custom control #8201

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make tab header a custom control #8227

Make tab header a custom control #8227

PankajBhojwani commented Nov 11, 2020 •

edited by DHowett

Loading

zadjii-msft left a comment

zadjii-msft Nov 16, 2020

PankajBhojwani Nov 16, 2020 •

edited

Loading

zadjii-msft left a comment

DHowett Nov 20, 2020

DHowett commented Nov 20, 2020

DHowett left a comment

ghost commented Nov 20, 2020

ghost commented Jan 28, 2021

Make tab header a custom control #8227

Make tab header a custom control #8227

Conversation

PankajBhojwani commented Nov 11, 2020 • edited by DHowett Loading

Validation Steps Performed

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft Nov 16, 2020

Choose a reason for hiding this comment

PankajBhojwani Nov 16, 2020 • edited Loading

Choose a reason for hiding this comment

zadjii-msft left a comment

Choose a reason for hiding this comment

DHowett Nov 20, 2020

Choose a reason for hiding this comment

DHowett commented Nov 20, 2020

DHowett left a comment

Choose a reason for hiding this comment

ghost commented Nov 20, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Jan 28, 2021

PankajBhojwani commented Nov 11, 2020 •

edited by DHowett

Loading

PankajBhojwani Nov 16, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.