Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value of background image stretch mode is fill instead of uniformToFill #8256

Closed
CookieHCl opened this issue Nov 13, 2020 · 4 comments · Fixed by #8280
Closed

Default value of background image stretch mode is fill instead of uniformToFill #8256

CookieHCl opened this issue Nov 13, 2020 · 4 comments · Fixed by #8280
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.6

Comments

@CookieHCl
Copy link

Environment

Windows build number: Microsoft Windows NT 10.0.19042.0
Windows Terminal version (if applicable): 1.4.3141.0, installed from chocolatey

Steps to reproduce

Add a background image to profile settings.
Don't set backgroundImageStretchMode so it can have default value.

Expected behavior

Background image should stretch like uniformToFill, because according to the documentation, this is the default value of backgroundImageStretchMode.

Actual behavior

Background image stretch like fill.

uniformToFill setting works if you explicitely set backgroundImageStretchMode, but it won't work in default value.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 13, 2020
@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 13, 2020 •
edited
Loading

@CookieHCl - Yep.. in the code the default behavior of BackgroundImageStretchMode within Profile is Fill.
I guess this is not intentional, as in TerminalSettings the default is UniformToFill (but it gets overridden by Profile).
I am not an owner or an expert but If you want to contribute a fix for it I will gladly assist.

@zadjii-msft
Copy link
Member

Oh well that's weird, and definitely not intentional. Good catch!

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Nov 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 13, 2020
@Don-Vito Don-Vito mentioned this issue Nov 15, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 15, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 16, 2020
@ghost ghost closed this as completed in #8280 Nov 16, 2020
@ghost ghost removed the In-PR This issue has a related PR label Nov 16, 2020
ghost pushed a commit that referenced this issue Nov 16, 2020
@Don-Vito
Fix default backgroundImageStretch to be uniformToFill (#8280)
77a204b 
This commit fixes the default value to comply with documentation.

Closes #8256
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 16, 2020
DHowett pushed a commit that referenced this issue Nov 20, 2020
@Don-Vito @DHowett
Fix default backgroundImageStretch to be uniformToFill (#8280)
1228897 
This commit fixes the default value to comply with documentation.

Closes #8256

(cherry picked from commit 77a204b)
DHowett pushed a commit that referenced this issue Nov 20, 2020
@Don-Vito @DHowett
Fix default backgroundImageStretch to be uniformToFill (#8280)
c2bc927 
This commit fixes the default value to comply with documentation.

Closes #8256

(cherry picked from commit 77a204b)
@ghost
Copy link

ghost commented Nov 20, 2020

🎉This issue was addressed in #8280, which has now been successfully released as Windows Terminal v1.4.3243.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 20, 2020

🎉This issue was addressed in #8280, which has now been successfully released as Windows Terminal Preview v1.5.3242.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.6
Development

Successfully merging a pull request may close this issue.

Fix default backgroundImageStretch to be uniformToFill Don-Vito/terminal
3 participants
@Don-Vito @zadjii-msft @CookieHCl