Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default backgroundImageStretch to be uniformToFill #8280

Merged
1 commit merged into from
Nov 16, 2020
Merged

Fix default backgroundImageStretch to be uniformToFill #8280

1 commit merged into from
Nov 16, 2020

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Nov 15, 2020 •
edited by DHowett
Loading

This commit fixes the default value to comply with documentation.

Closes #8256

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Nov 15, 2020
carlos-zamora
carlos-zamora approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks

@DHowett DHowett changed the title 8256: Default value of background image stretch mode is fill instead of uniformToFill Fix default backgroundImageStretch to be uniformToFill Nov 16, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 16, 2020
@ghost
Copy link

ghost commented Nov 16, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Nov 16, 2020
@ghost ghost merged commit 77a204b into microsoft:main Nov 16, 2020
@DHowett
Copy link
Member

DHowett commented Nov 16, 2020

Thank you :)

@DHowett DHowett removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Nov 20, 2020
DHowett pushed a commit that referenced this pull request Nov 20, 2020
@Don-Vito @DHowett
Fix default backgroundImageStretch to be uniformToFill (#8280)
1228897 
This commit fixes the default value to comply with documentation.

Closes #8256

(cherry picked from commit 77a204b)
DHowett pushed a commit that referenced this pull request Nov 20, 2020
@Don-Vito @DHowett
Fix default backgroundImageStretch to be uniformToFill (#8280)
c2bc927 
This commit fixes the default value to comply with documentation.

Closes #8256

(cherry picked from commit 77a204b)
@ghost
Copy link

ghost commented Nov 20, 2020

🎉Windows Terminal v1.4.3243.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 20, 2020
Closed
@ghost
Copy link

ghost commented Nov 20, 2020

🎉Windows Terminal Preview v1.5.3242.0 has been released which incorporates this pull request.:tada:

Handy links:

@Don-Vito Don-Vito deleted the fet/8256-uniform-fill-default branch December 3, 2020 17:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value of background image stretch mode is fill instead of uniformToFill
4 participants
@Don-Vito @DHowett @carlos-zamora @zadjii-msft