Fix a misdiagnosis in MSVC 17.11 #17723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-Build
DHowett
requested changes
Aug 15, 2024
src/buffer/out/OutputCell.cpp
Outdated
| @@ -9,6 +9,10 @@ | |||
| #include "../../types/inc/convert.hpp" | |||
| #include "../../inc/conattrs.hpp" | |||
|
|
|||
| // Misdiagnosis in MSVC 17.11: Referencing global constants in the member initializer | |||
There was a problem hiding this comment.
mark these with BODGY since that's how we mark things where we had to work around dumb platform problems
There was a problem hiding this comment.
can we file this on the compiler folx too?
There was a problem hiding this comment.
Hopefully it's fixed by this: https://developercommunity.visualstudio.com/t/C26493-false-positive-initializing-a-bas/10710542?q=26493
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.