Fix misalignment of Sixel image slices #17724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
j4james
commented
Aug 15, 2024
Comment on lines
686
to
+688
| const auto srcHeight = srcCellSize.height; | ||
| const auto dstWidth = srcWidth * dstCellSize.width / srcCellSize.width; | ||
| const auto dstHeight = srcHeight * dstCellSize.height / srcCellSize.height; | ||
| const auto dstHeight = dstCellSize.height; |
There was a problem hiding this comment.
This is just a little optimization that I noticed when investigating the rounding problems. The srcHeight is always srcCellSize.height, so the dstHeight should always be dstCellSize.height.
|
I'm assuming the audit failure is because the build server has a new version of the compiler. |
|
Don't worry about audit mode - #17723 |
lhecker
approved these changes
Aug 15, 2024
|
Thanks for this fix! Being able to display icons in the terminal is so nice, so many new possibilities, I have to write a Sixel conversion component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When we have a series of image slices of differing widths, which also
don't align with the cell boundaries, we can get rounding errors in the
scaling which makes the different slices appear misaligned.
This PR fixes the issue by removing the 4 pixel width alignment that was
enforced in the
ImageSliceclass, since that's not actually necessarywhen the pixels themselves are already 4 bytes in size. And without
that, the widths should be correctly aligned with the cell boundaries.
References and Relevant Issues
The initial Sixel implementation was added in PR #17421.
Validation Steps Performed
I've confirmed that this fixes the rendering glitches reported in
#17711, and all my existing Sixel tests still work as expected.
PR Checklist