Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more possible locations of MSBuild to the razzle.cmd script #436

Merged
merged 1 commit into from
May 7, 2019
Merged

Add a few more possible locations of MSBuild to the razzle.cmd script #436

merged 1 commit into from
May 7, 2019

Conversation

Gnbrkm41
Copy link
Contributor

@Gnbrkm41 Gnbrkm41 commented May 6, 2019

  • Add few more possible locations of MSBuild, including VS2019 and VS2017 Professional

Confirmed working on VS2019 Community. Hopefully it does on others as well 😀

Alternatively, write scripts in C# and use Microsoft.Build.Locator package?

* Add few more possible locations of MSBuild, including VS2019 and VS2017 Professional
@msftclas
Copy link

msftclas commented May 6, 2019

CLA assistant check
All CLA requirements met.

@Gnbrkm41 Gnbrkm41 changed the title Add a few more possible locations of MSBuild Add a few more possible locations of MSBuild to the razzle.cmd script May 6, 2019
@tannergooding
Copy link
Member

Another option is to just use vswhere.exe for locating a valid VS install that contains all required dependencies (including MSBuild, VC++, etc). You could also use CMake which also covers resolving the various C++ dependencies

@siennathesane
Copy link

+1 for vswhere.exe.

@DHowett-MSFT
Copy link
Contributor

vswhere would be awesome, but until then this'll do too.

@DHowett-MSFT DHowett-MSFT merged commit f1309ee into microsoft:master May 7, 2019
@tannergooding
Copy link
Member

Was going to log an issue tracking it, but it looks like #13 already does.

@zhiqiangyudev
Copy link

@Gnbrkm41 @DHowett-MSFT
I think there are some typos in this change. For example, the code below checks path %ProgramFiles% but sets %ProgramFiles(x86)%.

if exist "%ProgramFiles%\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin" (
    set MSBUILD="%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\msbuild.exe"
    goto :FOUND_MSBUILD
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants