Improve VS2017 detection by leveraging VSWhere.exe

[khouzam]

With support for multiple versions of VS2017, using vswhere.exe to detect the location of an appropriate install would be easier.

[amweiss]

Happy to get a PR in for this @zadjii-msft , would the preferred approach be to require choco install vswhere, just require a version of vswhere be on the PATH before running razzle or something else?

[DHowett-MSFT]

Is it possible to use the VSWhere that ships with the installer? @heaths may know if that’s okay.

…

________________________________ From: Adam Weiss <notifications@github.com> Sent: Wednesday, May 8, 2019 10:48:24 AM To: microsoft/Terminal Cc: Subscribed Subject: Re: [microsoft/Terminal] Improve VS2017 detection by leveraging VSWhere.exe (#13) Happy to get a PR in for this @zadjii-msft<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fzadjii-msft&data=01%7C01%7Cduhowett%40microsoft.com%7C1bd93eb3ba0a420be52408d6d3dd5ef8%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=z2mvfucA%2BZS2QMP1NAYWY7Gh2YQjRNwrT2QTNQ12i6E%3D&reserved=0> , would the preferred approach be to require choco install vswhere, just require a version of vswhere be on the PATH before running razzle or something else? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fmicrosoft%2FTerminal%2Fissues%2F13%23issuecomment-490584055&data=01%7C01%7Cduhowett%40microsoft.com%7C1bd93eb3ba0a420be52408d6d3dd5ef8%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=SBNCCVD6SSVYhM%2FrJmQtWdWnVK5NX5H8kRazFwCxYnk%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FADNHLGXQLGVUTOO6QCQOKELPUMG6RANCNFSM4DW2U4MA&data=01%7C01%7Cduhowett%40microsoft.com%7C1bd93eb3ba0a420be52408d6d3dd5ef8%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=0SCjXNqsyWPLCbh0WCGXCMVrSvmlHbU5oUyop8%2B%2BOBs%3D&reserved=0>.

[amweiss]

I have VS2019 and VS2019 Preview installed through the installer and the included VSWhere was not added to my path by default. I can try to locate vswhere to then locate msbuild, or just require it be on the path somehow for it to run.

[heaths]

We don't add it to the PATH because it's not an oft-enough used tool. Every directoryt added to PATH merely increases lookup time.

I recommend you acquire vswhere.exe via nuget or chocolatey, as described here. You can use the version we always install to "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" but you're rolling the dice on what features you get. For example, I just resolved a bug against vswhere because someone was using that path and trying to use the -find parameter that was added later. The only way to be sure you get the features you want is either use the ones we added initially (but that started in 15.2) or acquire it yourself. You can also redist it, which is what build systems like Azure Pipelines do (it's used by various built-in tasks).

[amweiss]

Thanks, I just got a version of razzle.cmd working with the chocolatey version and the -find parameter actually. It seems a bit heavy handed to put a choco install vswhere in razzle.cmd, but that would ensure it's a one step setup process. I'll post a PR in a few hours we can worth though, but on my environment it worked well.

[heaths]

Then why not use nuget? You already are using nuget generally, so put "vswhere" in your .nuget\packages.config file and it will get pulled if needed* whenever nuget restore is run in the repo. That's what a lot of our repos do - even vswhere itself. You could assume a hardcoded path in your script even, but you'll have to remember to update it if you ever update to a newer version in packages.config. Or do what we do and scan for it.

[amweiss]

I have a version started here: #606 but I can't get the build tools v141 working in VS2019. I don't want to mix that into this change so I want to get that sorted out before I make it a real PR.

[amweiss]

@khouzam you should be able to close this now that #606 was merged.

[DHowett-MSFT]

Fixed in #606,
Thanks!