Update razzle to use vswhere (#13) #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I can't figure out where in the nuget docs it specifies that |
DHowett-MSFT
approved these changes
May 9, 2019
This was referenced May 9, 2019
heaths
approved these changes
May 9, 2019
tools/razzle.cmd
Outdated
| ) | ||
|
|
||
| rem Add path to MSBuild Binaries | ||
| for /f "usebackq tokens=*" %%i in (`%VSWHERE% -latest -requires Microsoft.Component.MSBuild -find MSBuild\**\Bin\MSBuild.exe`) do set MSBUILD=%%i |
There was a problem hiding this comment.
You should add -products * if you want to also support Visual Studio Build Tools. By default, vswhere only supports finding Community, Professional, and Enterprise - our traditional VS SKUs.
zadjii-msft
reviewed
May 9, 2019
I can tackle these after work today, or on another PR later if you want this in sooner. |
|
@amweiss I'm in no rush - my unread inbox is expanding at just about the rate I reply to things :P |
|
Ha, I expected it would be worse than that by now 😁. Anyway, changes made. I did expand the scope a bit when I changed the readme to use |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ReneeGA2020
pushed a commit
to ReneeGA2020/Terminal
that referenced
this pull request
May 11, 2019
* Update razzle to use vswhere * Make vswhere pickup build tools * Make razzle handle errors better * Make bcz handle MSBUILD with spaces * Update readmes to use bcz and fix typo
Daniel15
reviewed
May 18, 2019
|
|
||
| rem Find vswhere | ||
| rem from https://github.com/microsoft/vs-setup-samples/blob/master/tools/vswhere.cmd | ||
| for /f "usebackq delims=" %%I in (`dir /b /aD /o-N /s "%~dp0..\packages\vswhere*" 2^>nul`) do ( |
There was a problem hiding this comment.
Is there a reason this needs to be a batch file rather than using PowerShell? I imagine this could be clearer than the obscure dir command if it used PowerShell.
There was a problem hiding this comment.
I was just following what was already there.
There was a problem hiding this comment.
Because not everyone likes Powershell. Our dev team is split between users of Powershell and cmd, so we have scripts for both.
metathinker
added a commit
to metathinker/console
that referenced
this pull request
May 29, 2019
Since version 5.0.2, NuGet has used the PATH environment variable to find MSBuild.exe before looking in other file paths. See NuGet change NuGet/NuGet.Client@21f2b07 (NuGet/NuGet.Client#2687 ). Unfortunately, in PR microsoft#606 , `tools\razzle.cmd` was changed to add the MSBuild.exe folder path in _quotes_ to the PATH environment variable. Windows itself is fine with this (you can type `msbuild` and MSBuild runs), but some tools are not, including NuGet itself, so you would get errors like this: ``` D:\GitHub\metathinker\console> where nuget C:\ProgramData\chocolatey\bin\nuget.exe D:\GitHub\metathinker\console\dep\nuget\nuget.exe D:\GitHub\metathinker\console> nuget restore OpenConsole.sln Illegal characters in path. ``` `razzle.cmd` runs NuGet itself, but does so before adding the MSBuild folder to the PATH, so it was not affected by this problem. This change fixes the issue by dequotifying the PATH, so that if you already had a newer version of NuGet on your PATH before running `tools\razzle.cmd`, that version will continue to work should you need to run `nuget restore` again (such as after a `git clean -dx`).
5 tasks
DHowett-MSFT
pushed a commit
that referenced
this pull request
May 29, 2019
…1046) Since version 5.0.2, NuGet has used the PATH environment variable to find MSBuild.exe before looking in other file paths. See NuGet change NuGet/NuGet.Client@21f2b07 (NuGet/NuGet.Client#2687 ). Unfortunately, in PR #606 , `tools\razzle.cmd` was changed to add the MSBuild.exe folder path in _quotes_ to the PATH environment variable. Windows itself is fine with this (you can type `msbuild` and MSBuild runs), but some tools are not, including NuGet itself, so you would get errors like this: ``` D:\GitHub\metathinker\console> where nuget C:\ProgramData\chocolatey\bin\nuget.exe D:\GitHub\metathinker\console\dep\nuget\nuget.exe D:\GitHub\metathinker\console> nuget restore OpenConsole.sln Illegal characters in path. ``` `razzle.cmd` runs NuGet itself, but does so before adding the MSBuild folder to the PATH, so it was not affected by this problem. This change fixes the issue by dequotifying the PATH, so that if you already had a newer version of NuGet on your PATH before running `tools\razzle.cmd`, that version will continue to work should you need to run `nuget restore` again (such as after a `git clean -dx`).
donno2048
added a commit
to donno2048/terminal
that referenced
this pull request
Sep 28, 2020
…#1046) Since version 5.0.2, NuGet has used the PATH environment variable to find MSBuild.exe before looking in other file paths. See NuGet change NuGet/NuGet.Client@21f2b07 (NuGet/NuGet.Client#2687 ). Unfortunately, in PR microsoft/terminal#606 , `tools\razzle.cmd` was changed to add the MSBuild.exe folder path in _quotes_ to the PATH environment variable. Windows itself is fine with this (you can type `msbuild` and MSBuild runs), but some tools are not, including NuGet itself, so you would get errors like this: ``` D:\GitHub\metathinker\console> where nuget C:\ProgramData\chocolatey\bin\nuget.exe D:\GitHub\metathinker\console\dep\nuget\nuget.exe D:\GitHub\metathinker\console> nuget restore OpenConsole.sln Illegal characters in path. ``` `razzle.cmd` runs NuGet itself, but does so before adding the MSBuild folder to the PATH, so it was not affected by this problem. This change fixes the issue by dequotifying the PATH, so that if you already had a newer version of NuGet on your PATH before running `tools\razzle.cmd`, that version will continue to work should you need to run `nuget restore` again (such as after a `git clean -dx`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of listing out all the locations for MSBuild, use the vswhere tool to find the location and add that directory to that path.