Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new parameter skipCertValidation #421

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Added new parameter skipCertValidation #421

merged 6 commits into from
Jan 13, 2023

Conversation

sergey-koryshev
Copy link
Contributor

@sergey-koryshev sergey-koryshev commented Jan 12, 2023 •
edited
Loading

Description: added new parameter --skipCertValidation (--skip-cert-validation) to group Global server command argument which allows to skip certificate validation during login

Related issue: #419

~ tfx login
TFS Cross Platform Command Line Interface v0.13.0
Copyright Microsoft Corporation
> Service URL: https://some-url
> Personal access token:
error: Error: Connection failed. Check your internet connection & collection URL.
error: Message: unable to get local issuer certificate

~ tfx login --skip-cert-validation
TFS Cross Platform Command Line Interface v0.13.0
Copyright Microsoft Corporation
> Service URL: https://some-url
> Personal access token:                                           
Logged in successfully

@sergey-koryshev sergey-koryshev requested review from a team as code owners January 12, 2023 08:04
@sergey-koryshev sergey-koryshev linked an issue Jan 12, 2023 that may be closed by this pull request
tfx cannot handle TLS certificate issued by corp certificate authority #419
Closed
@sergey-koryshev sergey-koryshev merged commit f40ae9c into master Jan 13, 2023
@sergey-koryshev sergey-koryshev mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismayilov-ismayil ismayilov-ismayil ismayilov-ismayil approved these changes

@DmitriiBobreshev DmitriiBobreshev DmitriiBobreshev approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

@wojgasior wojgasior wojgasior approved these changes

@vmapetr vmapetr vmapetr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tfx cannot handle TLS certificate issued by corp certificate authority
6 participants
@sergey-koryshev @vmapetr @wojgasior @kirill-ivlev @DmitriiBobreshev @ismayilov-ismayil