Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching value of skipCertValidation #436

Merged
merged 4 commits into from
May 22, 2023

Conversation

sergey-koryshev
Copy link
Contributor

@sergey-koryshev sergey-koryshev commented May 4, 2023

Description of issue

Implemented parameter skipCertValidation via PR #421 only take affected on login command and further commands lack of the value to be able to skip certificate validation

Description of fix

Implemented logic to save value of skipCertValidation to cache and read the value from it when webApi is initialized

@sergey-koryshev sergey-koryshev requested review from a team as code owners May 4, 2023 09:19
@KonstantinTyukalov
Copy link
Contributor

KonstantinTyukalov commented May 5, 2023

@sergey-koryshev question: What if user will want to re-enable SSL verification? What should he do in this case?
Should he cleanup the local cache?

@sergey-koryshev
Copy link
Contributor Author

sergey-koryshev commented May 5, 2023

@KonstantinTyukalov, user should perform logout and login commands again

@kirill-ivlev kirill-ivlev merged commit 59d2330 into master May 22, 2023
@max-zaytsev
Copy link
Contributor

/azp where

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants