-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plot method and data.py to Esri2020 dataset #405
Conversation
Looks like this is missing data.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually see a data.py
file in this PR.
I'm running the |
Tests are much faster now with this branch, awesome. When I run the tests, I'm seeing a leftover file that was not tracked by git. I'm assuming you meant to add this to git? I did so in the last commit. |
I thought, that it was desirable to push as few data files as possible and to keep it minimal with just the zipped data. |
It is, and if you properly copy all zip files to |
c496b11
to
c14302f
Compare
* add plot method and data.py * typo missed period * forgot data.py * Remove abc, add versionchanged * Update esri2020.py * fixed test and requested changes * Add uncompressed data file * add test coverage Co-authored-by: Caleb Robinson <calebrob6@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Since RasterDatasets should have their own plot method per #253, this PR adds a plot method and a data.py file to the Esri2020 dataset.