extract 7z archive part from 7z installers #405
Conversation
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
# Conflicts: # src/vcpkg/archives.cpp
| Checks::check_exit(VCPKG_LINE_INFO, | ||
| Strings::case_insensitive_ascii_equals(subext, ".7z"), | ||
| "Unable to extract 7z archive from Installer %s. Missing '.7z.exe' extension.", | ||
| archive); | ||
|
|
There was a problem hiding this comment.
Similar to my comment in the other PR I don't think we should treat .7z.exe differently than .exe.
There was a problem hiding this comment.
why not? vcpkg treats a number of extension differently here so treating sub-extensions differently is just the same. Since vcpkg is in control of the file name I don't really see an issue with that.
There was a problem hiding this comment.
also the other PR is just for exactly one tool (7z). This PR is for multiple tools having a .7z.exe installer package. (although it currently only applies to PortableGit since it is the only 7z installer package).
So the scope and application is a bit different to the other PR.
There was a problem hiding this comment.
I'm saying we should be interpreting all .exe as .7z.exe, because that is true for all the .exes we support passing to this right now. In the other example you checked the whole file name rather than just the extension in order to determine that we had a 7zip installer.
There was a problem hiding this comment.
Ok moved everything into the .exe path but I want to keep the requirement that the file is named .7z.exe before the extraction
|
Do we want this now that we have determined that we always need 7z anyway? |
as far as I know vcpkg downloads the console version of 7z which cannot extract executables which I learned in microsoft/vcpkg#23659 where i tried to use the console version but had to switch to the full version. |
|
I decided that it wasn't worth standing in front of this bus :) |
@BillyONeal This code can separate the 7z archive from the self extracting PortableGit installer (and probably more). The extracted 7z archive can then be passed to
cmake -E tarwithout having to use 7z to extract the installer silently.