Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-tool-llvm] more tool ports #23659

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Mar 19, 2022

@Neumann-A Neumann-A mentioned this pull request Mar 19, 2022
2 tasks
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 21, 2022
@Neumann-A Neumann-A marked this pull request as ready for review March 21, 2022 09:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-tool-7zip but no changes to version or port version.
-- Version: 21.07
-- Old SHA: 4f835111b322eb0d5598e14831f46be49b4e444a
-- New SHA: 6e1fbe6afd45c46403ba4fd80c6b4f23589b481f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JackBoosY
Copy link
Contributor

baseline issue?

@Neumann-A
Copy link
Contributor Author

baseline issue?

yes

@JackBoosY
Copy link
Contributor

One regression last.

@Neumann-A
Copy link
Contributor Author

One regression last.

According to the observations in other PRs this seems to be a baseline issue.

@JackBoosY
Copy link
Contributor

@Neumann-A Yes, I'm fixing this.

@JackBoosY
Copy link
Contributor

Depends on #23999

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 6, 2022
@JackBoosY JackBoosY removed their assignment Oct 14, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 28, 2022
@eli-schwartz
Copy link

Slightly OT

Ports in general need to understand this difference between the system installed Python and a built-from-source Python.

Tell that the meson guys. I just recently needed to patch a port using python.dependency() or something similar. People upstream are hardcoding interpreter = libraries.

Furthermore python scripts like meson can have a minimum python version requirement which is not reflected by the current handling within vcpkg. We should deal with the python + meson situation just like cmake where we force the (minimum) version required. meson requires 3.7 which seems currently be ok with vcpkg but what is with other scripts which might require 3.10 ? (I don't want to discuss this in: I just want to raise the issue here since I feel like that has been forgotten.) /OT

The minimum python version is actually very relevant for Meson, too, as you pointed out here: #27117 (comment)
People are running vcpkg on Ubuntu 18.04 which ships with a system python 3.6 (with pip install meson that just downloads an old version of Meson that runs fine, so you can cross your fingers and hope the project you are building doesn't require a newer version of Meson than the last one to support 3.6).

The python interpreter to build compiled CPython extensions can be solved by using meson machine files to point the python = "binaries" entry to the one that vcpkg installs as a non-tool.

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:discussion labels Nov 3, 2022
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 4, 2022
@BillyONeal
Copy link
Member

Under the current tools proposal I am in favor of vcpkg-tool-llvm but not vcpkg-tool-7zip. Will let you know after disucssion.

# Conflicts:
#	ports/kinectsdk1/vcpkg.json
#	ports/kinectsdk2/vcpkg.json
#	versions/baseline.json
#	versions/k-/kinectsdk1.json
#	versions/k-/kinectsdk2.json
@Neumann-A Neumann-A changed the title [vcpkg-tool-(7zip|llvm)] more tool ports [vcpkg-tool-llvm] more tool ports Apr 19, 2023
@BillyONeal BillyONeal added depends:tool-ports Needs tool ports to be a better understood area before proceeding and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jun 27, 2024
@Cheney-W Cheney-W marked this pull request as draft October 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! depends:tool-ports Needs tool ports to be a better understood area before proceeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants