[vcpkg-artifacts] Fix end to end development. #586
Conversation
Thanks to @fearthecowboy for help on this one. I considered ripping out the rush dependency, since it seems like we are only ever going to have one meaningful "project", and the dependency deduplication we need seems to be already done by pnpm (rather than npm), but after talking with @fearthecowboy I've decided to not go there since we still have rush linking the test project in. Unfortunately, there does not appear to be an effiicent way to build the typescript parts out-of-source, since they depend on node_modules which is put into the source tree. This adds a vcpkg.ps1 which does the same "environment hacking" as the in-development ce.ps1, teaches CMakeLists.txt to invoke rush and the typescript compiler as necessary, and teaches vcpkg.exe to use a hard-coded-into-the-binary path to the source tree when that in-development setting is turned on. The previous "always download latest ce bits" behavior is retained for folks who build vcpkg.exe from source and don't want to arrange for node and rush to be available.
|
|
| "outDir": "./dist", | ||
| "rootDir": ".", | ||
| "types": [ | ||
| "node", | ||
| "mocha" | ||
| ], | ||
| "inlineSourceMap": true, |
There was a problem hiding this comment.
Was inlineSourceMap causing a problem?
There was a problem hiding this comment.
Was
inlineSourceMapcausing a problem?
No, but it's already specified in the common one here:
vcpkg-tool/ce/common/tsconfig.json
Line 11 in 88386bb
(I deduplicated any such settings I noticed)
…igger infinite loops.
|
|
||
| add_custom_command( | ||
| OUTPUT | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/ce/ce/node_modules" |
There was a problem hiding this comment.
This is an imperfect output connection; if the packages.json is modified it won't be regenerated. I'm not sure what the right definition would be at this time; maybe just having a "stamp" file that we create after running the rush commands.
There was a problem hiding this comment.
Everything related to the ecmascript dependency detection is imperfect unfortunately. This is "good enough" to do development work; unfortunately there doesn't seem to be a way to make it conclusively correct as long as Rush is involved.
Thanks to @fearthecowboy for help on this one.
I considered ripping out the rush dependency, since it seems like we are only ever going to have one meaningful "project", and the dependency deduplication we need seems to be already done by pnpm (rather than npm), but after talking with @fearthecowboy I've decided to not go there since we still have rush linking the test project in.
Unfortunately, there does not appear to be an effiicent way to build the typescript parts out-of-source, since they depend on node_modules which is put into the source tree.
This adds a vcpkg.ps1 which does the same "environment hacking" as the in-development ce.ps1, teaches CMakeLists.txt to invoke rush and the typescript compiler as necessary, and teaches vcpkg.exe to use a hard-coded-into-the-binary path to the source tree when that in-development setting is turned on.
The previous "always download latest ce bits" behavior is retained for folks who build vcpkg.exe from source and don't want to arrange for node and rush to be available.
Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1551959