-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-artifacts] Fix end to end development. #586
Merged
Merged
Commits on Jun 13, 2022
-
[vcpkg-artifacts] Fix end to end development.
Thanks to @fearthecowboy for help on this one. I considered ripping out the rush dependency, since it seems like we are only ever going to have one meaningful "project", and the dependency deduplication we need seems to be already done by pnpm (rather than npm), but after talking with @fearthecowboy I've decided to not go there since we still have rush linking the test project in. Unfortunately, there does not appear to be an effiicent way to build the typescript parts out-of-source, since they depend on node_modules which is put into the source tree. This adds a vcpkg.ps1 which does the same "environment hacking" as the in-development ce.ps1, teaches CMakeLists.txt to invoke rush and the typescript compiler as necessary, and teaches vcpkg.exe to use a hard-coded-into-the-binary path to the source tree when that in-development setting is turned on. The previous "always download latest ce bits" behavior is retained for folks who build vcpkg.exe from source and don't want to arrange for node and rush to be available.
Configuration menu - View commit details
-
Copy full SHA for 703a087 - Browse repository at this point
Copy the full SHA 703a087View commit details -
Configuration menu - View commit details
-
Copy full SHA for c28bf00 - Browse repository at this point
Copy the full SHA c28bf00View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae2705e - Browse repository at this point
Copy the full SHA ae2705eView commit details
Commits on Jun 14, 2022
-
Guard VCPKG_ARTIFACTS_DEVELOPMENT for a recent enough CMake to not tr…
…igger infinite loops.
Configuration menu - View commit details
-
Copy full SHA for 130b139 - Browse repository at this point
Copy the full SHA 130b139View commit details -
Configuration menu - View commit details
-
Copy full SHA for f278699 - Browse repository at this point
Copy the full SHA f278699View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6782ee - Browse repository at this point
Copy the full SHA a6782eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3b195 - Browse repository at this point
Copy the full SHA 9c3b195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef7024 - Browse repository at this point
Copy the full SHA 3ef7024View commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 68e8ec0 - Browse repository at this point
Copy the full SHA 68e8ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09da874 - Browse repository at this point
Copy the full SHA 09da874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29bc405 - Browse repository at this point
Copy the full SHA 29bc405View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.