[Localization] Ursa Minor 🐻 #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MissingDependency
DocumentedFieldsSuggestUpdate
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
reviewed
Jul 21, 2022
BillyONeal
requested changes
Jul 21, 2022
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
ras0219-msft
reviewed
Aug 5, 2022
There was a problem hiding this comment.
In general, start with messages in the (single) cpp file that uses them. Only move them to the common area when they're used at least twice. I see that this is now intended based on #615
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
vicroms
requested changes
Aug 9, 2022
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
|
Would you be willing to take the changes in https://github.com/BillyONeal/vcpkg-tool/tree/ursa-major-working ? |
BillyONeal
approved these changes
Aug 18, 2022
|
Added those changes as Javier confirmed they were OK in person |
vicroms
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localized messages in the following files:
It also adds a new message argument: supports_expression