Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lz4] update to 1.9.3 #16860

Merged
merged 2 commits into from
Apr 9, 2021
Merged

[lz4] update to 1.9.3 #16860

merged 2 commits into from
Apr 9, 2021

Conversation

Thieum
Copy link
Contributor

@Thieum Thieum commented Mar 24, 2021

@Thieum
[lz4] update to 1.9.3
4e25e39 
- Update lz4 to 1.9.3 https://github.com/lz4/lz4/releases/tag/v1.9.3
- tested as an install dependency for libarchive on x86-windows and x64-windows.
@Thieum Thieum marked this pull request as ready for review March 24, 2021 13:47
@Thieum Thieum mentioned this pull request Mar 24, 2021
Merged
@Thieum
Copy link
Contributor Author

Thieum commented Mar 24, 2021

Error at least with cmake could be related the same issue we have in #16845

@Thieum
Copy link
Contributor Author

Thieum commented Mar 24, 2021

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 16860 in repo microsoft/vcpkg

@Thieum Thieum mentioned this pull request Mar 24, 2021
Merged
@NancyLi1013 NancyLi1013 self-assigned this Mar 25, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 25, 2021
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Mar 25, 2021 •
edited
Loading

The failures on x64-linux are like this:

c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory

This error is not related with this PR, which needs to depend on the changes in PR #15808.
Edit: This problem has been fixed via PR #16954.

@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 25, 2021
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 7, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your update @Thieum.

@vicroms vicroms merged commit 9ab06a4 into microsoft:master Apr 9, 2021
@Thieum Thieum deleted the lz4 branch April 9, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thieum @NancyLi1013 @vicroms