Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qt5-base] Fix glib link issues on linux #16954

Merged
merged 27 commits into from
Apr 6, 2021
Merged

[vcpkg baseline][qt5-base] Fix glib link issues on linux #16954

merged 27 commits into from
Apr 6, 2021

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Mar 29, 2021 •
edited by PhoebeHui
Loading

Fix CI issues in:
#16948
#16897

closes #16942

Edit: Failure in above PRs:
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory

@NancyLi1013 NancyLi1013 self-assigned this Mar 30, 2021
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 30, 2021
@NancyLi1013 NancyLi1013 changed the title [qt5-base] Fix glib link issues on linux [vcpkg baseline][qt5-base] Fix glib link issues on linux Mar 30, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Mar 30, 2021
Closed
@JackBoosY
Copy link
Contributor

Ping @ras0219 @ras0219-msft for review this PR.
Can we have other better ways to achieve this?

@Neumann-A
Copy link
Contributor Author

Just a note: Passing --triplet=${TARGET_TRIPLET} to the list command does nothing. (I would at least assume it will filter the list.)

vicroms
vicroms approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicroms
Copy link
Member

vicroms commented Mar 30, 2021

An alternative is to run vcpkg x-package-info {port}:{triplet} --x-installed --x-json, which will produce a features array as part of the JSON output.

ras0219-msft
ras0219-msft requested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really prefer to avoid this approach (recursive vcpkg to inspect installed files).

If nothing else, harfbuzz should install a file that we can test for existence (such as share/harfbuzz/has_glib_feature.

ports/qt5-base/portfile.cmake Outdated Show resolved Hide resolved
ports/qt5-base/portfile.cmake Outdated Show resolved Hide resolved
ports/qt5-base/portfile.cmake Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

The forest issue would be fixed by PR #16836

@PhoebeHui PhoebeHui mentioned this pull request Apr 2, 2021
Merged
This was referenced Apr 2, 2021
Merged
Merged
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Apr 5, 2021
@JackBoosY
Copy link
Contributor

Ping @ras0219 @ras0219-msft for review this PR again.

strega-nil
strega-nil suggested changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor cmake changes

ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake Outdated Show resolved Hide resolved
ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake Outdated Show resolved Hide resolved
ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake Outdated Show resolved Hide resolved
ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake Show resolved Hide resolved
ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake Outdated Show resolved Hide resolved
ports/vcpkg-pkgconfig-get-modules/portfile.cmake Outdated Show resolved Hide resolved
@Neumann-A @strega-nil
Apply suggestions from code review
2c21038 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@vicroms
Copy link
Member

vicroms commented Apr 5, 2021

Waiting for clean CI

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:discussion labels Apr 6, 2021
@vicroms vicroms merged commit 1bb0fe6 into microsoft:master Apr 6, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 7, 2021
Merged
@Neumann-A Neumann-A deleted the fix_qt5_base branch April 7, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@vicroms vicroms vicroms approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cmake|linux] build failure
7 participants
@Neumann-A @JackBoosY @vicroms @PhoebeHui @strega-nil @ras0219-msft @NancyLi1013