[llvm] add features enable-{eh,ffi,bindings,terminfo,threads} #16877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abique
force-pushed
the
llvm-no-curses
branch
3 times, most recently
from
81d9f25
to
6773251
Compare
|
Related to #16232 |
|
They do not overlap through. |
|
Yay, all the tests passed, this looks good to me. |
abique
changed the title
Cheney-W
added
category:port-feature
yurybura
suggested changes
Mar 26, 2021
yurybura
reviewed
Mar 26, 2021
Cheney-W
added
requires:author-response
and removed
info:reviewed
|
@yurybura Thank you very much for the review 👍 |
|
It seems that the osgearth failure is unrelated right? |
|
Yes, this is a CI issue, it will be fixed by PR: #16904. |
JackBoosY
added
the
depends:different-pr
Cheney-W
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing features to LLVM