-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdal] Fix build for non-Windows targets #17698
Conversation
Still waiting for approval of curl changes (#17790). |
TODO: gdal.pc FTR, CI doesn't build many depending port at the moment:
(And no gdal build for arm, uwp.) |
Ping @JackBoosY. GIthub states that I "marked this pull request as ready for review 2 days ago". |
PS: I will fix the LIBRARY typo together with possible review comments. |
cc @Neumann-A for review this PR. |
Kindly reminder for reviews. Cannot look at gdal updates, or upstreaming any changes, before sufficient agreement on the current PR. And a huge number of dependencies makes this PR volatile until merged. |
Hm, it is somewhat out of scope. This PR is mostly about the autotools build system, apart from general port file improvements. #17609 is reported for Windows. The comments are using CMake language, but GDAL isn't. And I don't have the MSVC toolchain. I cannot build gdal[core,libspatialite]:x64-windows outside CI. |
@dg0yt Okay, that's fine. |
I'd like @Neumann-A review this PR. |
Does this issue also fix #15526? |
After re-reading, #15526 is about using (static) gdal with MSVC. The whole area of using gdal will probably need more work. It depends on whether usage requirements are handled
As I wrote in #17698 (comment), there is a varying level of CI coverage for using gdal in different triplets. I guess there are also lots of workaround in consuming ports. Improving this situation is for coming PRs. The focus of this PR is on controlling what is pulled in when building gdal, thus stabilizing what needs to be pulled in when linking statically to gdal. |
gdal 3.3.1 is released, too. https://github.com/OSGeo/gdal/releases/tag/v3.3.1 |
@dg0yt have tested gdal on windows with msvc (dynamic amd x64). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs the minor change
I'm aware of that. But I can't push new things while waiting for review. This PR already triggered countless work on incoming dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM waiting for CI results
I verified that |
What does your PR fix?
This PR fixes building gdal for non-Windows systems ([GDAL] On Linux completly broken #9068).
It also restructures the portfile for better maintainability.
It includes significant patching to configure.ac. There seems to be no better way to handle vcpkg's release+debug filesystem layout.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes