-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mapnik] new port #18849
[Mapnik] new port #18849
Conversation
@mathisloge ,If this pr is ready for review, please turn to open state |
Yes. Might take some time until upstream gets merged. |
standalone mapnik demo which tests the most common functionalities
|
updated to latest commit. It adds |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry for the CI failures, we backed out the check that caused everything to fail for the last 10 hours or so |
@mathisloge For a more convenient CI trigger: git commit --allow-empty -m "[skip actions] Trigger CI"
git push |
LGTM now, thanks for your efforts. It's has taken so long time on this port. @mathisloge |
@NancyLi1013 thanks for your reviews! |
Thanks for the new port! |
Describe the pull request
adds mapnik without forking the mapnik repository. However, this PR needs the current master.
Adds the mapbox-geometry and mapbox-polyline ports.(added in #16838).What does your PR fix?
Fixes [New Port Request] <Mapnik> #7526
Since i have screwed up the previous PR [Mapnik] new port #14628 i've done this one again.
Which triplets are supported/not supported? Have you updated the CI baseline?
needs CI test
Does your PR follow the maintainer guide? yes
todo