-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lcms] Backfill compat for lcms::lcms #20034
Conversation
Concerning the removal of the vcpkg/ports/libraw/lcms2_debug_fix.patch Line 25 in 615547c
|
ab3e428
to
aa602e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7e044226c8a6f43dac7d9e0efd8edbf8ff5ecd04 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/lcms.json b/versions/l-/lcms.json
index 7e02096..a41a3b6 100644
--- a/versions/l-/lcms.json
+++ b/versions/l-/lcms.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "2325b67210a3ae0feb4348fb889e1e55436363b8",
+ "git-tree": "d10fd604e23cd1145f606998d19f607641bce13b",
"version": "2.12",
"port-version": 1
},
aa602e5
to
abce47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy as long as @c72578 's comment is addressed.
Because vcpkg builds each flavor separately, the results will still be correct even given the patch: CMake will only ever find a "release" version (which is actually the debug version when built in debug) and will use that regardless of the consumer's configuration. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Backfill a few issues unaddressed in #19551:
d
suffix in debuglcms::lcms
since there's no need to break existing usersversion
scheme