Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcms] Backfill compat for lcms::lcms #20034

Merged
merged 6 commits into from
Sep 23, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 14 additions & 47 deletions ports/lcms/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,50 +1,18 @@
cmake_minimum_required(VERSION 3.5)

option(CMAKE_VERBOSE_MAKEFILE "Create verbose makefile" OFF)
option(BUILD_SHARED_LIBS "Create lcms2 as a shared library" ON)

project(little-cms)

set(CMAKE_DEBUG_POSTFIX d)
file(GLOB SRCS src/*.c)

add_library(lcms2
"${CMAKE_CURRENT_LIST_DIR}/src/cmstypes.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsvirt.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmswtpnt.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsxform.c"
"${CMAKE_CURRENT_LIST_DIR}/src/lcms2.def"
"${CMAKE_CURRENT_LIST_DIR}/src/lcms2_internal.h"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsalpha.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmscam02.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmscgats.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmscnvrt.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmserr.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsgamma.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsgmt.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmshalf.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsintrp.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsio0.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsio1.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmslut.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsmd5.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsmtrx.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsnamed.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsopt.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmspack.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmspcs.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsplugin.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmsps2.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmssamp.c"
"${CMAKE_CURRENT_LIST_DIR}/src/cmssm.c"
)
add_library(lcms2 ${SRCS} src/lcms2.def)

if(BUILD_SHARED_LIBS)
target_compile_options(lcms2 PRIVATE -DCMS_DLL_BUILD)
target_compile_options(lcms2 PUBLIC -DCMS_DLL)
endif()
target_compile_options(lcms2 PRIVATE -DUNICODE -D_UNICODE)

target_include_directories(lcms2 PRIVATE "${CMAKE_CURRENT_LIST_DIR}/include")
target_include_directories(lcms2 PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>)
set_target_properties(lcms2 PROPERTIES PUBLIC_HEADER "${CMAKE_CURRENT_LIST_DIR}/include/lcms2.h;${CMAKE_CURRENT_LIST_DIR}/include/lcms2_plugin.h")

# Generate pkg-config file
Expand All @@ -58,30 +26,29 @@ SET(exec_prefix "\${prefix}")
SET(libdir "\${exec_prefix}/${CMAKE_INSTALL_LIBDIR}")
SET(includedir "\${prefix}/include")
CONFIGURE_FILE(lcms2.pc.in "${PROJECT_BINARY_DIR}/lcms2.pc" @ONLY)
IF(CMAKE_BUILD_TYPE MATCHES Debug)
# Add CMAKE_DEBUG_POSTFIX
file(READ "${PROJECT_BINARY_DIR}/lcms2.pc" LCMS2_PC)
string(REPLACE "-llcms2" "-llcms2${CMAKE_DEBUG_POSTFIX}" LCMS2_PC "${LCMS2_PC}")
file(WRITE "${PROJECT_BINARY_DIR}/lcms2.pc" "${LCMS2_PC}")
ENDIF()

install(TARGETS lcms2
EXPORT lcmsConfig
EXPORT lcms2Config
RUNTIME DESTINATION "bin"
LIBRARY DESTINATION "lib"
ARCHIVE DESTINATION "lib"
PUBLIC_HEADER DESTINATION "include"
COMPONENT dev
)

INSTALL(FILES ${PROJECT_BINARY_DIR}/lcms2.pc DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)

export(TARGETS lcms2
install(EXPORT lcms2Config
DESTINATION "share/lcms2"
NAMESPACE lcms2::
FILE "share/lcms/lcmsConfig.cmake"
)

install(EXPORT lcmsConfig
# Backwards compatibility for previous vcpkg users
add_library(lcms INTERFACE)
target_link_libraries(lcms INTERFACE lcms2)


install(TARGETS lcms EXPORT lcms-targets)
install(EXPORT lcms-targets
DESTINATION "share/lcms"
NAMESPACE lcms2::
NAMESPACE lcms::
)
4 changes: 0 additions & 4 deletions ports/lcms/CONTROL

This file was deleted.

16 changes: 10 additions & 6 deletions ports/lcms/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,19 @@ vcpkg_from_github(

file(COPY "${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt" DESTINATION "${SOURCE_PATH}")

vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
)
vcpkg_cmake_configure(SOURCE_PATH "${SOURCE_PATH}")
vcpkg_cmake_install()

vcpkg_install_cmake()
vcpkg_copy_pdbs()
vcpkg_fixup_cmake_targets()
vcpkg_cmake_config_fixup(PACKAGE_NAME lcms2)
vcpkg_cmake_config_fixup()
NancyLi1013 marked this conversation as resolved.
Show resolved Hide resolved
vcpkg_fixup_pkgconfig()
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
file(WRITE "${CURRENT_PACKAGES_DIR}/share/lcms/lcms-config.cmake" [[
include(CMakeFindDependencyMacro)
find_dependency(lcms2 CONFIG)
include(${CMAKE_CURRENT_LIST_DIR}/lcms-targets.cmake)
]])

file(INSTALL "${SOURCE_PATH}/COPYING" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright)
file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" "${CURRENT_PACKAGES_DIR}/share/${PORT}")
ras0219-msft marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions ports/lcms/usage
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The package lcms provides CMake targets:

find_package(lcms2 CONFIG REQUIRED)
target_link_libraries(main PRIVATE lcms2::lcms2)
17 changes: 17 additions & 0 deletions ports/lcms/vcpkg.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "lcms",
"version": "2.12",
"port-version": 1,
"description": "Little CMS.",
"homepage": "https://github.com/mm2/Little-CMS",
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]
}
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -3070,7 +3070,7 @@
},
"lcms": {
"baseline": "2.12",
"port-version": 0
"port-version": 1
},
"leaf": {
"baseline": "0.2.2",
Expand Down
5 changes: 5 additions & 0 deletions versions/l-/lcms.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "2325b67210a3ae0feb4348fb889e1e55436363b8",
"version": "2.12",
"port-version": 1
},
{
"git-tree": "0020f124dcd6fa36e8ab5edad1efc85c59c51a56",
"version-string": "2.12",
Expand Down