Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sciter-js] Updated sciter-js to 4.4.8.31 #23357

Merged
merged 13 commits into from
Mar 11, 2022

Conversation

VuYeK
Copy link
Contributor

@VuYeK VuYeK commented Mar 2, 2022

Describe the pull request

  • What does your PR fix?

Bumps the version of sciter-js from 4.4.8.16 to 4.4.8.31. In new version there is no sciter-sqlite.dll.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all, No

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@VuYeK VuYeK changed the title [sciter-js] Updated sciter-js to 4.4.8.31 Draft: [sciter-js] Updated sciter-js to 4.4.8.31 Mar 2, 2022
@VuYeK VuYeK changed the title Draft: [sciter-js] Updated sciter-js to 4.4.8.31 [sciter-js] Updated sciter-js to 4.4.8.31 Mar 2, 2022
@VuYeK
Copy link
Contributor Author

VuYeK commented Mar 2, 2022

Something is wrong with that tests

@VuYeK VuYeK changed the title [sciter-js] Updated sciter-js to 4.4.8.31 Draft: [sciter-js] Updated sciter-js to 4.4.8.31 Mar 3, 2022
@VuYeK VuYeK changed the title Draft: [sciter-js] Updated sciter-js to 4.4.8.31 [sciter-js] Updated sciter-js to 4.4.8.31 Mar 3, 2022
@FrankXie05 FrankXie05 self-assigned this Mar 3, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 3, 2022
@FrankXie05
Copy link
Contributor

@VuYeK Looks like there is a problem with the CI test, I will re-request the test and identify the problem. :)

@JackBoosY JackBoosY closed this Mar 3, 2022
@JackBoosY JackBoosY reopened this Mar 3, 2022
@JackBoosY
Copy link
Contributor

Close and re-open this PR to re-active our PR suggestion agent.

@JackBoosY
Copy link
Contributor

@VuYeK Can you please open a new PR to commit this changes? It seems our agent has some problems.
Sorry for that.

@VuYeK
Copy link
Contributor Author

VuYeK commented Mar 10, 2022

@JackBoosY I have closed and reopened PR, still some errors

@JackBoosY
Copy link
Contributor

JackBoosY commented Mar 10, 2022

@VuYeK So can you please open another PR to commit this changes?
This is not needed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 857bccdad005957391854448a15ba30e8c118503 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sciter-js.json b/versions/s-/sciter-js.json
index e3805cd..de8eaee 100644
--- a/versions/s-/sciter-js.json
+++ b/versions/s-/sciter-js.json
@@ -1,14 +1,14 @@
-{
-  "versions": [
-    {
-      "git-tree": "c1ab21374bbcd674911ff5093e8ce859334f7352",
-      "version-string": "4.4.8.31",
-      "port-version": 0
-    },
-    {
-      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
-      "version-string": "4.4.8.16",
-      "port-version": 0
-    }
-  ]
-}
+{
+  "versions": [
+    {
+      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
+      "version": "4.4.8.31",
+      "port-version": 0
+    },
+    {
+      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
+      "version-string": "4.4.8.16",
+      "port-version": 0
+    }
+  ]
+}

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 857bccdad005957391854448a15ba30e8c118503 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sciter-js.json b/versions/s-/sciter-js.json
index c162ad7..de8eaee 100644
--- a/versions/s-/sciter-js.json
+++ b/versions/s-/sciter-js.json
@@ -1,15 +1,14 @@
-{
-  "versions": [
-    {
-      "git-tree": "c1ab21374bbcd674911ff5093e8ce859334f7352",
-      "version": "4.4.8.31",
-
-      "port-version": 0
-    },
-    {
-      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
-      "version-string": "4.4.8.16",
-      "port-version": 0
-    }
-  ]
-}
+{
+  "versions": [
+    {
+      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
+      "version": "4.4.8.31",
+      "port-version": 0
+    },
+    {
+      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
+      "version-string": "4.4.8.16",
+      "port-version": 0
+    }
+  ]
+}

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 857bccdad005957391854448a15ba30e8c118503 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sciter-js.json b/versions/s-/sciter-js.json
index 1266335..de8eaee 100644
--- a/versions/s-/sciter-js.json
+++ b/versions/s-/sciter-js.json
@@ -1,16 +1,14 @@
-{
-  "versions": [
-    {
-      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
-
-      "version": "4.4.8.31",
-
-      "port-version": 0
-    },
-    {
-      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
-      "version-string": "4.4.8.16",
-      "port-version": 0
-    }
-  ]
-}
+{
+  "versions": [
+    {
+      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
+      "version": "4.4.8.31",
+      "port-version": 0
+    },
+    {
+      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
+      "version-string": "4.4.8.16",
+      "port-version": 0
+    }
+  ]
+}

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 857bccdad005957391854448a15ba30e8c118503 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sciter-js.json b/versions/s-/sciter-js.json
index de1c7ff..de8eaee 100644
--- a/versions/s-/sciter-js.json
+++ b/versions/s-/sciter-js.json
@@ -1,14 +1,14 @@
-{
-  "versions": [
-    {
-      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
-      "version": "4.4.8.31",
-      "port-version": 0
-    },
-    {
-      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
-      "version-string": "4.4.8.16",
-      "port-version": 0
-    }
-  ]
-}
+{
+  "versions": [
+    {
+      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
+      "version": "4.4.8.31",
+      "port-version": 0
+    },
+    {
+      "git-tree": "d8b949852b38b18eac5c4fa0c25282d531c596fd",
+      "version-string": "4.4.8.16",
+      "port-version": 0
+    }
+  ]
+}

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 857bccdad005957391854448a15ba30e8c118503 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sciter-js.json b/versions/s-/sciter-js.json
index 9d78156..de8eaee 100644
--- a/versions/s-/sciter-js.json
+++ b/versions/s-/sciter-js.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "c1ab21374bbcd674911ff5093e8ce859334f7352",
+      "git-tree": "708c5345421be4b92ea288a7447a4c228fc98413",
       "version": "4.4.8.31",
       "port-version": 0
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sciter-js/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 11, 2022
@vicroms vicroms merged commit 5bce441 into microsoft:master Mar 11, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 14, 2022
* master: (64 commits)
  [baseline] [python3] fix bz2(d) search on linux (microsoft#23525)
  [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042)
  [earcut.hpp] New port (microsoft#23507)
  [libssh2] Fix deleted configfiles (microsoft#23509)
  [python3] Update to Python 3.10.2. (microsoft#23156)
  [qt5-webengine] Fix apply patch failed (microsoft#23484)
  [llvm] Fix LLVM install for 'utils' feature (microsoft#23399)
  [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357)
  [GTL] Add new port (microsoft#23400)
  [raylib] Fix cannot find -lglfw on Linux (microsoft#23348)
  [yato] fix arm build by updating (microsoft#23406)
  [ois] fix pkgconfig file not installed on windows (microsoft#23426)
  Fix the dependency of installing arrow with the parquet feature (microsoft#23423)
  [libjpeg-turbo] Fix usage when building static (microsoft#23427)
  [sentencepiece] Clarify supported triplets (microsoft#23438)
  [zpp-bits] Add new port (microsoft#23458)
  [lionkor-commandline] Add new port (microsoft#23471)
  [libde265] fix static linkage (microsoft#23479)
  [libheif] fix license (microsoft#23480)
  [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants