Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentencepiece] Clarify supported triplets #23438

Merged
merged 4 commits into from
Mar 11, 2022
Merged

[sentencepiece] Clarify supported triplets #23438

merged 4 commits into from
Mar 11, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Mar 8, 2022 •
edited
Loading

Describe the pull request

sentencepiece:arm64-windows=fail
sentencepiece:arm-uwp=fail
sentencepiece:x64-uwp=fail
sentencepiece:x64-windows=fail
sentencepiece:x86-windows=fail

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes, but still working on this PR

github-actions[bot]
github-actions bot approved these changes Mar 8, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sentencepiece/vcpkg.json

Valid values for the license field can be found in the documentation

@Thomas1664 Thomas1664 closed this Mar 8, 2022
@Thomas1664
Copy link
Contributor Author

Reopening because CI failures aren't my fault

@Thomas1664 Thomas1664 reopened this Mar 9, 2022
@Thomas1664 Thomas1664 marked this pull request as ready for review March 9, 2022 11:00
github-actions[bot]
github-actions bot approved these changes Mar 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sentencepiece/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05
Copy link
Contributor

@Thomas1664 Thanks for posting this PR, but I would like to ask you why you need to modify the support in ci.baseline.txt? Did it change upstream?

@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 10, 2022
@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Thomas1664
Copy link
Contributor Author

@Thomas1664 Thanks for posting this PR, but I would like to ask you why you need to modify the support in ci.baseline.txt? Did it change upstream?

@FrankXie05 I added supports in vcpkg.json to make it more obvious that this ports only supports static linking. Because of supports I removed it from CI baseline.

@FrankXie05
Copy link
Contributor

@Thomas1664 got it, thanks for your contribution. :)

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 10, 2022
@Thomas1664 Thomas1664 changed the title [sentencepiece] [sentencepiece] Clarify supported triplets Mar 10, 2022
@vicroms vicroms merged commit 1c67923 into microsoft:master Mar 11, 2022
@Thomas1664 Thomas1664 deleted the sentencepiece branch March 11, 2022 22:06
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 14, 2022
@ekilmer
Merge branch 'master' into more-lief
cc8c5a7 
* master: (64 commits)
  [baseline] [python3] fix bz2(d) search on linux (microsoft#23525)
  [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042)
  [earcut.hpp] New port (microsoft#23507)
  [libssh2] Fix deleted configfiles (microsoft#23509)
  [python3] Update to Python 3.10.2. (microsoft#23156)
  [qt5-webengine] Fix apply patch failed (microsoft#23484)
  [llvm] Fix LLVM install for 'utils' feature (microsoft#23399)
  [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357)
  [GTL] Add new port (microsoft#23400)
  [raylib] Fix cannot find -lglfw on Linux (microsoft#23348)
  [yato] fix arm build by updating (microsoft#23406)
  [ois] fix pkgconfig file not installed on windows (microsoft#23426)
  Fix the dependency of installing arrow with the parquet feature (microsoft#23423)
  [libjpeg-turbo] Fix usage when building static (microsoft#23427)
  [sentencepiece] Clarify supported triplets (microsoft#23438)
  [zpp-bits] Add new port (microsoft#23458)
  [lionkor-commandline] Add new port (microsoft#23471)
  [libde265] fix static linkage (microsoft#23479)
  [libheif] fix license (microsoft#23480)
  [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building package sentencepiece
3 participants
@Thomas1664 @FrankXie05 @vicroms