Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf-ble-driver] Fix version errors #28036

Closed
wants to merge 1 commit into from

Conversation

h1562075881
Copy link

[nrf ble driver] Fix the inconsistency between the source code version and the output version

@Adela0814 Adela0814 self-assigned this Nov 28, 2022
@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Nov 28, 2022
@Adela0814
Copy link
Contributor

@h1562075881 Please upgrade the port-version via vcpkg x-add-version nrf-ble-driver.

@Adela0814 Adela0814 changed the title [nrf ble driver] Fix version errors [nrf-ble-driver] Fix version errors Nov 28, 2022
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO NordicSemiconductor/pc-ble-driver
REF v4.1.4
REF "v${NRF_BLE_VERSION}"
Copy link
Contributor

@autoantwort autoantwort Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use ${VERSION} instead

@Adela0814
Copy link
Contributor

Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again.

@Adela0814 Adela0814 marked this pull request as draft December 22, 2022 08:18
@Adela0814
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.

@Adela0814 Adela0814 closed this Jan 13, 2023
mickael9 added a commit to mickael9/vcpkg that referenced this pull request Jun 7, 2023
- Fixed version inconsistency (microsoft#28036)
- Used correct tag with precompiled hex files
mickael9 added a commit to mickael9/vcpkg that referenced this pull request Jun 7, 2023
- Fixed version inconsistency (microsoft#28036)
- Used correct tag with precompiled hex files
vicroms pushed a commit that referenced this pull request Jun 12, 2023
… gcc-11.2.0 (#31873)

* [nrf-ble-driver] fix compilation with gcc 11.2.0

PR: NordicSemiconductor/pc-ble-driver#272

* [nrf-ble-driver] fix version & use correct tag

- Fixed version inconsistency (#28036)
- Used correct tag with precompiled hex files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants