Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf-ble-driver] Fix incorrect tag, version number & compilation with gcc-11.2.0 #31873

Merged
merged 2 commits into from
Jun 12, 2023
Merged

[nrf-ble-driver] Fix incorrect tag, version number & compilation with gcc-11.2.0 #31873

merged 2 commits into from
Jun 12, 2023

Conversation

mickael9
Copy link
Contributor

@mickael9 mickael9 commented Jun 7, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@mickael9
Copy link
Contributor Author

mickael9 commented Jun 7, 2023

@microsoft-github-policy-service agree

@mickael9 mickael9 marked this pull request as ready for review June 7, 2023 17:20
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jun 8, 2023
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 JonLiu1993 marked this pull request as draft June 8, 2023 02:46
@mickael9 mickael9 marked this pull request as ready for review June 8, 2023 16:18
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2023
@vicroms vicroms merged commit 1ba9a25 into microsoft:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mickael9 @JonLiu1993 @vicroms