Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5solid] Add imobile feature #33888

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

See also #33246

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 20, 2023
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Sep 22, 2023

Feature imobile is tested successfully in the following triplet:

x64-windows
x64-windows-static

Not tested on x86-windows as errors in dependency qt5-base blocked me, but it has nothing to do with your changes:

-- Installing x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: G:/kf5solid/downloads/tools/jom/jom-1.1.3/jom.exe /J 9 install
    Working Directory: G:/kf5solid/buildtrees/qt5-base/x86-windows-dbg
    Error code: 2
    See logs for more information:
      G:\kf5solid\buildtrees\qt5-base\package-x86-windows-dbg-out.log
      G:\kf5solid\buildtrees\qt5-base\package-x86-windows-dbg-err.log

Call Stack (most recent call first):
  ports/qt5-base/cmake/install_qt.cmake:106 (vcpkg_execute_required_process)
  ports/qt5-base/portfile.cmake:396 (install_qt)
  scripts/ports.cmake:147 (include)

package-x86-windows-rel-err.log:

jom 1.1.3 - empower your cores

Cannot open G:/kf5solid/packages/qt5-base_x86-windows/tools/qt5/bin/qmake.exe: The process cannot access the file because it is being used by another process.jom: G:\kf5solid\buildtrees\qt5-base\x86-windows-rel\qmake\Makefile.qmake-aux.Release [install_qmake] Error 3
jom: G:\kf5solid\buildtrees\qt5-base\x86-windows-rel\qmake\Makefile.qmake-aux [release-install] Error 2
jom: G:\kf5solid\buildtrees\qt5-base\x86-windows-rel\Makefile [sub-qmake-qmake-aux-pro-install_subtargets] Error 2

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2023
@vicroms vicroms merged commit 78ba971 into microsoft:master Sep 22, 2023
15 checks passed
@xiaozhuai xiaozhuai deleted the dev-kf5solid branch September 25, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants