[kf5solid] Fix baseline regression, cleanup #34085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
changed the title
JonLiu1993
added
the
category:port-bug
This was referenced Sep 28, 2023
|
Thanks! |
clementperon
pushed a commit
to clementperon/vcpkg
that referenced
this pull request
Oct 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #33888.
The portfile didn't pass FEATURE_OPTIONS to the CMake build, allowing to find optional dependencies when they weren't selected. This breaks later builds from cached artifact as in vcpkg CI https://dev.azure.com/vcpkg/public/_build/results?buildId=94631.