[soundtouch] Fix WASM build by using -O3 instead of -Ofast #37103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
fix-soundtouch-emscripten
branch
from
0d8b645 to
e95aa95
Compare
13 tasks
FrankXie05
added
the
category:port-bug
FrankXie05
approved these changes
Mar 4, 2024
dg0yt
reviewed
Mar 5, 2024
Comment on lines
+19
to
+28
| if(MSVC) | ||
| set(COMPILE_DEFINITIONS /O2 /fp:fast) | ||
| - set(COMPILE_OPTIONS ) | ||
| else() | ||
| - set(COMPILE_OPTIONS -Ofast) | ||
| + if(EMSCRIPTEN) | ||
| + list(APPEND COMPILE_OPTIONS -O3) | ||
| + else() | ||
| + list(APPEND COMPILE_OPTIONS -Ofast) | ||
| + endif() |
There was a problem hiding this comment.
Shouldn't this follow the vcpkg toolchain and build type instead of being hardcoded?
There was a problem hiding this comment.
I guess so, but if upstream wants to force optimizations, better to have something that builds 🤷
dg0yt
reviewed
Mar 5, 2024
Comment on lines
+1
to
+8
| From 405c4586d4556982fd5bbddf1c70bc4815465c51 Mon Sep 17 00:00:00 2001 | ||
| Date: Sat, 2 Mar 2024 23:02:06 +0100 | ||
| Subject: [PATCH] Use -O3 instead of -Ofast when targeting Emscripten (WASM) | ||
|
|
||
| --- | ||
| CMakeLists.txt | 9 +++++++-- | ||
| 1 file changed, 7 insertions(+), 2 deletions(-) | ||
|
|
There was a problem hiding this comment.
This is auto-generated by git format-patch. Not really needed indeed, but IMO doesn't hurt either (the file overview is nice to see what a patch does at a glance)
fwcd
added a commit
to fwcd/vcpkg
that referenced
this pull request
Mar 5, 2024
…#37103) Fixes microsoft#37102 The `-Ofast` option is unfortunately not supported by Emscripten yet (as per emscripten-core/emscripten#11884), therefore we have to patch around this for now. Once the upstream PR is merged and released, we can remove this: https://codeberg.org/soundtouch/soundtouch/pulls/29 - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file.
daschuer
added a commit
to mixxxdj/vcpkg
that referenced
this pull request
Mar 5, 2024
[soundtouch] Fix WASM build by using -O3 instead of -Ofast (microsoft#37103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37102
The
-Ofastoption is unfortunately not supported by Emscripten yet (as per emscripten-core/emscripten#11884), therefore we have to patch around this for now.Once the upstream PR is merged and released, we can remove this: https://codeberg.org/soundtouch/soundtouch/pulls/29
./vcpkg x-add-version --alland committing the result.