-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[soundtouch] Fix WASM build by using -O3 instead of -Ofast #37103
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
From 405c4586d4556982fd5bbddf1c70bc4815465c51 Mon Sep 17 00:00:00 2001 | ||
Date: Sat, 2 Mar 2024 23:02:06 +0100 | ||
Subject: [PATCH] Use -O3 instead of -Ofast when targeting Emscripten (WASM) | ||
|
||
--- | ||
CMakeLists.txt | 9 +++++++-- | ||
1 file changed, 7 insertions(+), 2 deletions(-) | ||
|
||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 14f23e8..dabcb9c 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -3,11 +3,16 @@ project(SoundTouch VERSION 2.3.2 LANGUAGES CXX) | ||
|
||
include(GNUInstallDirs) | ||
|
||
+set(COMPILE_OPTIONS) | ||
+ | ||
if(MSVC) | ||
set(COMPILE_DEFINITIONS /O2 /fp:fast) | ||
- set(COMPILE_OPTIONS ) | ||
else() | ||
- set(COMPILE_OPTIONS -Ofast) | ||
+ if(EMSCRIPTEN) | ||
+ list(APPEND COMPILE_OPTIONS -O3) | ||
+ else() | ||
+ list(APPEND COMPILE_OPTIONS -Ofast) | ||
+ endif() | ||
Comment on lines
+19
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this follow the vcpkg toolchain and build type instead of being hardcoded? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess so, but if upstream wants to force optimizations, better to have something that builds 🤷 |
||
endif() | ||
|
||
##################### | ||
-- | ||
2.43.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cruft...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto-generated by
git format-patch
. Not really needed indeed, but IMO doesn't hurt either (the file overview is nice to see what a patch does at a glance)