Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonConverter on named params object properties ignored #735

Closed
AArnott opened this issue Nov 11, 2021 · 0 comments · Fixed by #736
Closed

JsonConverter on named params object properties ignored #735

AArnott opened this issue Nov 11, 2021 · 0 comments · Fixed by #736
Milestone
v2.10

Comments

@AArnott
Copy link
Member

AArnott commented Nov 11, 2021

With #651 we regressed honoring [JsonConverter] attributes applied to custom params objects.
@AArnott AArnott added this to the v2.10 milestone Nov 11, 2021
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Nov 11, 2021
@AArnott
Add test that asserts [JsonConverter] attributed properties on cust…
685a6da 
…om named args objects are honored

Test case for microsoft#735
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Nov 11, 2021
@AArnott
Honor [JsonConverter] attributes on properties of custom params obj…
adadf4b 
…ects

Fixes microsoft#735
@AArnott AArnott mentioned this issue Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10
Development

Successfully merging a pull request may close this issue.

Honor [JsonConverter] attributes on properties of custom params objects AArnott/vs-streamjsonrpc
1 participant
@AArnott