Honor [JsonConverter] attributes on properties of custom params objects
#736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om named args objects are honored Test case for microsoft#735
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.02%
==========================================
Files 60 60
Lines 5228 5231 +3
==========================================
+ Hits 4786 4788 +2
- Misses 442 443 +1
Continue to review full report at Codecov.
|
milopezc
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change made in #651 regressed LSP when it changed from asking Newtonsoft.Json to serialize an entire custom params object to serializing each individual property. There are a bunch of considerations for each property that we were no longer taking into account (e.g. JsonConverter, default value skipping properties).
Instead, we go back to letting JsonSerializer take care of the whole object, and simply delete the problematic property when the serializer includes it.
Fixes #735
@rruizGit You may be amused to learn I'm going back to your version of the fix, which gets the job done without breaking stuff as my version of the fix did.